Date: Sun, 01 Mar 2009 11:37:53 -0600 From: Richard Todd <rmtodd@ichotolot.servalan.com> To: freebsd-current@freebsd.org Cc: Alexander Motin <mav@FreeBSD.org> Subject: Re: ata problems @ r189170 Message-ID: <x77i39rvny.fsf@ichotolot.servalan.com> In-Reply-To: <servalan.mailinglist.fbsd-current/49A9ACF2.3090101@FreeBSD.org> (Alexander Motin's message of "Sat, 28 Feb 2009 23:30:26 %2B0200") References: <49A99EA7.4000202@errno.com> <49A9A09A.2070900@freebsd.org> <49A9AA83.1030300@freebsd.org> <49A9ACF2.3090101@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Motin <mav@FreeBSD.org> writes: > Looks like while fixing small problems I have found bigger ones. Try > please this patch against HEAD, it reverts r189166, r189091 and > partially r188903: > > http://people.freebsd.org/~mav/ata.rollback.patch > > If it works, I will stop for some time to cool down and search for > better solution. I too found problems with the "new" ATA code you'd tried -- not any obvious error messages or timeouts from the ATA system, but it was obviously sometimes returning corrupt data, as evidenced by ZFS giving checksum errors. (Yay for ZFS for catching this!) Moving to the current (post-r189195) code that has your aforementioned rollback patch seems to have fixed the problem, and I've been "zfs scrubbing" the disks without any sign of errors. So something in the patches you reverted apparently can cause silent data corruption that could go unnoticed without a higher-level checksum like ZFS has. Something you might want to watch out for when reworking those patches.... If it matters, this is on a Core2Duo system in amd64 mode, with a Intel DP965LT motherboard; the SATA controller is, if I recall right, ICH8: atapci1: <Intel AHCI controller> port 0x3108-0x310f,0x3114-0x3117,0x3100-0x3107,0x3110-0x3113,0x3020-0x303f mem 0xe8325000-0xe83257ff irq 19 at device 31.2 on pci0 atapci1@pci0:0:31:2: class=0x010601 card=0x514d8086 chip=0x28248086 rev=0x02 hdr=0x00
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?x77i39rvny.fsf>