Date: Wed, 21 Oct 2015 05:09:29 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 203909] [MAINTAINER] devel/sope: Add CFLAGS supressing compiler warnings Message-ID: <bug-203909-13-OY1TGD6iRR@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-203909-13@https.bugs.freebsd.org/bugzilla/> References: <bug-203909-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203909 --- Comment #4 from Kubilay Kocak <koobs@FreeBSD.org> --- @Euan, thanks for your response. Proposed changes to ports are always viewed in the context of: will be pushed to users, and should be 'production' ready. In that context, the content, format and structure of changes should strictly be for consumers, not maintainers/committers. Some committers do however, sometimes include certain bits of a ports contents in an .if (MAINTAINER_MODE) conditional, but are usually only included if related to testing / QA, updating a port, or functionality that might otherwise be valuable to users as well, on an ongoing basis. In this case, CFLAGS are trivially overridable by the user in /etc/make.conf, and the warnings themselves (while padding build logs), are not explicitly required to be fixed in the port, as opposed to upstream directly. Having said that, its a good thing that you'd like to refine the port and it's compilation to that extent, but in doing so does not preclude removing -Werror in particular, as it is not safe across architectures, versions and environments, and can (and has) caused issues with package building before. TLDR; * Changes should be 'production ready for users' by default. * If it's not strictly necessary, causing impact, or providing additional value, consider upstreaming first by default. * No -Werror in CFLAGS (some ports explicitly remove it from inappropriate upstream defaults) -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-203909-13-OY1TGD6iRR>