Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Oct 2004 18:24:22 +0400
From:      Slawa Olhovchenkov <slw@zxy.spb.ru>
To:        "M. Warner Losh" <imp@bsdimp.com>
Cc:        cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/kern kern_shutdown.c
Message-ID:  <20041008142421.GA24021@mail.acropolis.ru>
In-Reply-To: <20041004.163808.73381384.imp@bsdimp.com>
References:  <200410041313.i94DDN1w064795@repoman.freebsd.org> <20041004.095538.105191591.imp@bsdimp.com> <20041004223426.GJ460@wantadilla.lemis.com> <20041004.163808.73381384.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 04, 2004 at 04:38:08PM -0600, M. Warner Losh wrote:

> In message: <20041004223426.GJ460@wantadilla.lemis.com>
>             "Greg 'groggy' Lehey" <grog@FreeBSD.org> writes:
> : On Monday,  4 October 2004 at  9:55:38 -0600, M. Warner Losh wrote:
> : > In message: <200410041313.i94DDN1w064795@repoman.freebsd.org>
> : >             Poul-Henning Kamp <phk@FreeBSD.org> writes:
> : >> phk         2004-10-04 13:13:23 UTC
> : >>
> : >>   FreeBSD src repository
> : >>
> : >>   Modified files:
> : >>     sys/kern             kern_shutdown.c
> : >>   Log:
> : >>   Change the perfectly precise message
> : >>          printf("No buffers busy after final sync");
> : >>   to
> : >>          printf("All buffers synced.");
> : >>   in order to not leave the users wondering if there should be.
> : >
> : > Any not reason to delete
> : >  	printf("All buffers synced.");
> : > entirely?
> : 
> : I like to see some message to confirm that the process is over and
> : done with.  Something goes wrong often enough that it's good to know
> : that it worked this time.
> 
> The machine will either shutoff, reboot or print the 'hit any key to
> reboot' message in addition.  

... or get kernel trap (intel MB D865GBF w/ P4 3Ghz 90nm, last current/5.3-B7).

> Do we really need an additional message
> saying that we did the right thing?

It's good.

-- 
Slawa Olhovchenkov



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041008142421.GA24021>