Date: Tue, 5 Jan 2010 05:29:21 -0800 From: David Wolfskill <david@catwhisker.org> To: hackers@freebsd.org Subject: Patch to Makefile.inc1 to mention which kernel config is being installed Message-ID: <20100105132921.GN86359@bunrab.catwhisker.org>
next in thread | raw e-mail | index | archive | help
--D5HQcwfjqNcvOcn2 Content-Type: multipart/mixed; boundary="35KUG7rixYqtz4l+" Content-Disposition: inline --35KUG7rixYqtz4l+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In the usual case where a machine is (only) used to build its own kernel, this is admittedly of no benefit. But for "build machines" that are used to build kernels for other machines (as well as themselves), it kinda bugged me that I was being told which kernels were being built, but not which one was being installed. Sure, I could recall that the first one built was being installed ... but why not have Makefile.inc1 tell us, just as it tells us which is being built? Before the patch, grepping through the typescript of a build for "^>>>" would yield: >>> Building an up-to-date make(1) >>> World build started on Mon Jan 4 04:47:37 PST 2010 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies >>> stage 4.4: building everything >>> World build completed on Mon Jan 4 05:00:40 PST 2010 >>> Kernel build for GENERIC started on Mon Jan 4 05:00:40 PST 2010 >>> stage 1: configuring the kernel >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3.1: making dependencies >>> stage 3.2: building everything >>> Kernel build for GENERIC completed on Mon Jan 4 05:01:32 PST 2010 >>> Kernel build for ALBERT started on Mon Jan 4 05:01:32 PST 2010 >>> stage 1: configuring the kernel >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3.1: making dependencies >>> stage 3.2: building everything >>> Kernel build for ALBERT completed on Mon Jan 4 05:02:20 PST 2010 >>> Kernel build for JANUS started on Mon Jan 4 05:02:20 PST 2010 >>> stage 1: configuring the kernel >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3.1: making dependencies >>> stage 3.2: building everything >>> Kernel build for JANUS completed on Mon Jan 4 05:03:07 PST 2010 >>> Installing kernel >>> Making hierarchy >>> Installing everything >>> Removing old files (only deletes safe to delete libs) >>> Old files removed >>> Removing old directories >>> Old directories removed >>> stage 2.2: rebuilding the object tree >>> stage 4.4: building everything >>> Removing old libraries >>> Old libraries removed After the patch: >>> Building an up-to-date make(1) >>> World build started on Tue Jan 5 04:48:19 PST 2010 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies >>> stage 4.4: building everything >>> World build completed on Tue Jan 5 05:01:26 PST 2010 >>> Kernel build for GENERIC started on Tue Jan 5 05:01:26 PST 2010 >>> stage 1: configuring the kernel >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3.1: making dependencies >>> stage 3.2: building everything >>> Kernel build for GENERIC completed on Tue Jan 5 05:03:28 PST 2010 >>> Kernel build for ALBERT started on Tue Jan 5 05:03:28 PST 2010 >>> stage 1: configuring the kernel >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3.1: making dependencies >>> stage 3.2: building everything >>> Kernel build for ALBERT completed on Tue Jan 5 05:05:12 PST 2010 >>> Kernel build for JANUS started on Tue Jan 5 05:05:12 PST 2010 >>> stage 1: configuring the kernel >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3.1: making dependencies >>> stage 3.2: building everything >>> Kernel build for JANUS completed on Tue Jan 5 05:06:53 PST 2010 >>> Installing kernel GENERIC >>> Making hierarchy >>> Installing everything >>> Removing old files (only deletes safe to delete libs) >>> Old files removed >>> Removing old directories >>> Old directories removed >>> stage 2.2: rebuilding the object tree >>> stage 4.4: building everything >>> Removing old libraries >>> Old libraries removed Attached patch is against head; for the above, I had patched stable/7. Thoughts? Peace, david --=20 David H. Wolfskill david@catwhisker.org Depriving a girl or boy of an opportunity for education is evil. See http://www.catwhisker.org/~david/publickey.gpg for my public key. --35KUG7rixYqtz4l+ Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="Makefile.inc1.diff" Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 201492) +++ Makefile.inc1 (working copy) @@ -817,7 +817,7 @@ false .endif @echo "--------------------------------------------------------------" - @echo ">>> Installing kernel" + @echo ">>> Installing kernel ${INSTALLKERNEL}" @echo "--------------------------------------------------------------" cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \ ${CROSSENV} PATH=${TMPPATH} \ --35KUG7rixYqtz4l+-- --D5HQcwfjqNcvOcn2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iEYEARECAAYFAktDPrAACgkQmprOCmdXAD00agCdEDkCxBRGnB0XEp+hWMjoyAwa zmsAnjvqPMpE+Rk/T9SZK3f0w242HWGn =j3ae -----END PGP SIGNATURE----- --D5HQcwfjqNcvOcn2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100105132921.GN86359>