Date: Mon, 17 Jul 2017 19:57:36 +0000 From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: [Bug 220785] audio/jack: Add and enable COOKEDMODE option, Use GitHub Message-ID: <bug-220785-12827-9fPZvDNMSz@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-220785-12827@https.bugs.freebsd.org/bugzilla/> References: <bug-220785-12827@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220785 --- Comment #11 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 184447 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D184447 patch > +SUB_FILES=3D pkg-message Why? The file doesn't seem to contain any %% macros such e.g., %%PREFIX%%. > +DYNSIMD_CONFIGURE_ENABLE=3Ddynsimd >=20 > CFLAGS+=3D -I${BDB_INCLUDE_DIR} > +COOKEDMODE_CFLAGS+=3D -DOPTION_COOKEDMODE=3D1 > LIBS+=3D -L${BDB_LIB_DIR} > INSTALL_TARGET=3D install-strip - Rename DYNSIMD to RTCPU which already has default description vi Mk/bsd.options.desc.mk - Don't mix option helpers and generic definitions/flags. It's confusing and breaks existing style in the file. For one, see how other _CONFIGURE_ENABLE= are grouped. - Maybe replace +=3D with plain =3D as _CFLAGS helper already appends (not overrides) the value > +OPTIONS_DEFINE=3D ALSA DOXYGEN READLINE SNDIO COOKEDMODE > +OPTIONS_DEFINE_i386=3D ALSA DOXYGEN READLINE SNDIO COOKEDMODE DYNSIMD > +OPTIONS_DEFINE_amd64=3D ALSA DOXYGEN READLINE SNDIO COOKEDMODE DYNSIMD > +OPTIONS_DEFAULT=3D READLINE COOKEDMODE > +OPTIONS_DEFAULT_i386=3D READLINE COOKEDMODE DYNSIMD > +OPTIONS_DEFAULT_amd64=3D READLINE COOKEDMODE DYNSIMD Can you deduplicate OPTIONS_*_${ARCH} ? Mk/bsd.options.mk already appends (= not overrides) arch-specific options. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220785-12827-9fPZvDNMSz>