Date: Sat, 26 Jul 2014 10:33:03 -0400 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: Ian Lepore <ian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r269112 - head/sys/boot/arm/at91/boot2 Message-ID: <CAJ5_RoBe-NWuxUgefoLvOCshe_HoYsekcHNpuyOGxh5g%2BT4YLg@mail.gmail.com> In-Reply-To: <201407260409.s6Q49i20065578@svn.freebsd.org> References: <201407260409.s6Q49i20065578@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 26, 2014 at 12:09 AM, Ian Lepore <ian@freebsd.org> wrote: > Author: ian > Date: Sat Jul 26 04:09:43 2014 > New Revision: 269112 > URL: http://svnweb.freebsd.org/changeset/base/269112 > > Log: > The 'flags' variable is conflicting with some inline code in a header > file > ("variable flags shadows a global..."), just rename this variable to > wish away the problem. > Not trying to pick on you, but we have lots of places where we get "variable <foo> shadows a global..." -- we have a global variable 'buf' in the kernel namespace, for one :) Do we think it's a good use of our time to try and get this to zero instances? -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoBe-NWuxUgefoLvOCshe_HoYsekcHNpuyOGxh5g%2BT4YLg>