Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Jun 2012 11:04:27 GMT
From:      Miroslav Lachman <000.fbsd@quip.cz>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/169484: lang/php53-extensions conversion to OptionsNG
Message-ID:  <201206271104.q5RB4RJ4079255@red.freebsd.org>
Resent-Message-ID: <201206271110.q5RBACRT098042@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         169484
>Category:       ports
>Synopsis:       lang/php53-extensions conversion to OptionsNG
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 27 11:10:12 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Miroslav Lachman
>Release:        9.0-RELEASE
>Organization:
codeLab.cz
>Environment:
FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC 2012     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Port lang/php5-extensions doesn't work with OptionsNG. Default extensions are always installed even if deselected.

More described in ports mailinglist
http://lists.freebsd.org/pipermail/freebsd-ports/2012-June/076337.html
>How-To-Repeat:
cd /usr/ports/lang/php53-extensions/
make config

Deselect some default options. Then make install and all default extensions will be installed.
>Fix:
Convert make file to OptionsNG as was done for lang/php5-extensions in PR ports/168946

Patch is attached.

Patch attached with submission follows:

--- Makefile.orig	2012-05-16 11:46:45.000000000 +0200
+++ Makefile	2012-06-26 19:02:22.000000000 +0200
@@ -24,86 +24,7 @@
 
 LATEST_LINK=	${PORTNAME}${PKGNAMESUFFIX}
 
-WITH_CTYPE=	yes
-WITH_DOM=	yes
-WITH_FILTER=	yes
-WITH_HASH=	yes
-WITH_ICONV=	yes
-WITH_JSON=	yes
-WITH_PDO=	yes
-WITH_PDO_SQLITE=yes
-WITH_PHAR=	yes
-WITH_POSIX=	yes
-WITH_SESSION=	yes
-WITH_SIMPLEXML=	yes
-WITH_SQLITE=	yes
-WITH_SQLITE3=	yes
-WITH_TOKENIZER=	yes
-WITH_XML=	yes
-WITH_XMLREADER=	yes
-WITH_XMLWRITER=	yes
-
-OPTIONS=	BCMATH          "bc style precision math functions" off \
-		BZ2             "bzip2 library support" off \
-		CALENDAR        "calendar conversion support" off \
-		CTYPE           "ctype functions" on \
-		CURL            "CURL support" off \
-		DBA             "dba support" off \
-		DOM             "DOM support" on \
-		EXIF            "EXIF support" off \
-		FILEINFO        "fileinfo support" off \
-		FILTER          "input filter support" on \
-		FTP             "FTP support" off \
-		GD              "GD library support" off \
-		GETTEXT         "gettext library support" off \
-		GMP             "GNU MP support" off \
-		HASH            "HASH Message Digest Framework" on \
-		ICONV           "iconv support" on \
-		IMAP            "IMAP support" off \
-		INTERBASE       "Interbase 6 database support (Firebird)" off \
-		JSON            "JavaScript Object Serialization support" on \
-		LDAP            "OpenLDAP support" off \
-		MBSTRING        "multibyte string support" off \
-		MCRYPT          "Encryption support" off \
-		MSSQL           "MS-SQL database support" off \
-		MYSQL           "MySQL database support" off \
-		MYSQLI          "MySQLi database support" off \
-		ODBC            "ODBC support" off \
-		OPENSSL         "OpenSSL support" off \
-		PCNTL           "pcntl support (CLI only)" off \
-		PDF             "PDFlib support (implies GD)" off \
-		PDO             "PHP Data Objects Interface (PDO)" on \
-		PDO_SQLITE      "PDO sqlite driver" on \
-		PGSQL           "PostgreSQL database support" off \
-		PHAR            "phar support" on \
-		POSIX           "POSIX-like functions" on \
-		PSPELL          "pspell support" off \
-		READLINE        "readline support (CLI only)" off \
-		RECODE          "recode support" off \
-		SESSION         "session support" on \
-		SHMOP           "shmop support" off \
-		SIMPLEXML       "simplexml support" on \
-		SNMP            "SNMP support" off \
-		SOAP            "SOAP support" off \
-		SOCKETS         "sockets support" off \
-		SQLITE          "sqlite support" on \
-		SQLITE3         "sqlite3 support" on \
-		SYBASE_CT       "Sybase database support" off \
-		SYSVMSG         "System V message support" off \
-		SYSVSEM         "System V semaphore support" off \
-		SYSVSHM         "System V shared memory support" off \
-		TIDY            "TIDY support" off \
-		TOKENIZER       "tokenizer support" on \
-		WDDX            "WDDX support (implies XML)" off \
-		XML             "XML support" on \
-		XMLREADER       "XMLReader support" on \
-		XMLRPC          "XMLRPC-EPI support" off \
-		XMLWRITER       "XMLWriter support" on \
-		XSL             "XSL support (Implies DOM)" off \
-		ZIP             "ZIP support" off \
-		ZLIB            "ZLIB support" off
-
-ALL_OPTIONS=	BCMATH BZ2 CALENDAR CTYPE CURL DBA \
+OPTIONS_DEFINE=	BCMATH BZ2 CALENDAR CTYPE CURL DBA \
 		DOM EXIF FILEINFO FILTER FTP GD GETTEXT \
 		GMP HASH ICONV IMAP INTERBASE JSON LDAP MBSTRING MCRYPT \
 		MSSQL MYSQL MYSQLI \
@@ -113,10 +34,89 @@
 		TIDY TOKENIZER WDDX XML XMLREADER XMLRPC XMLWRITER XSL \
 		ZIP ZLIB
 
+BCMATH_DESC=		bc style precision math functions
+BZ2_DESC=		bzip2 library support
+CALENDAR_DESC=		calendar conversion support
+CTYPE_DESC=		ctype functions
+CURL_DESC=		CURL support
+DBA_DESC=		dba support
+DOM_DESC=		DOM support
+EXIF_DESC=		EXIF support
+FILEINFO_DESC=		fileinfo support
+FILTER_DESC=		input filter support
+FTP_DESC=		FTP support
+GD_DESC=		GD library support
+GETTEXT_DESC=		gettext library support
+GMP_DESC=		GNU MP support
+HASH_DESC=		HASH Message Digest Framework
+ICONV_DESC=		iconv support
+IMAP_DESC=		IMAP support
+INTERBASE_DESC=		Interbase 6 database support (Firebird)
+JSON_DESC=		JavaScript Object Serialization support
+LDAP_DESC=		OpenLDAP support
+MBSTRING_DESC=		multibyte string support
+MCRYPT_DESC=		Encryption support
+MSSQL_DESC=		MS-SQL database support
+MYSQL_DESC=		MySQL database support
+MYSQLI_DESC=		MySQLi database support
+ODBC_DESC=		ODBC support
+OPENSSL_DESC=		OpenSSL support
+PCNTL_DESC=		pcntl support (CLI only)
+PDF_DESC=		PDFlib support (implies GD)
+PDO_DESC=		PHP Data Objects Interface (PDO)
+PDO_SQLITE_DESC=	PDO sqlite driver
+PGSQL_DESC=		PostgreSQL database support
+PHAR_DESC=		phar support
+POSIX_DESC=		POSIX-like functions
+PSPELL_DESC=		pspell support
+READLINE_DESC=		readline support (CLI only)
+RECODE_DESC=		recode support
+SESSION_DESC=		session support
+SHMOP_DESC=		shmop support
+SIMPLEXML_DESC=		simplexml support
+SNMP_DESC=		SNMP support
+SOAP_DESC=		SOAP support
+SOCKETS_DESC=		sockets support
+SQLITE_DESC=		sqlite support
+SQLITE3_DESC=		sqlite3 support
+SYBASE_CT_DESC=		Sybase database support
+SYSVMSG_DESC=		System V message support
+SYSVSEM_DESC=		System V semaphore support
+SYSVSHM_DESC=		System V shared memory support
+TIDY_DESC=		TIDY support
+TOKENIZER_DESC=		tokenizer support
+WDDX_DESC=		WDDX support (implies XML)
+XML_DESC=		XML support
+XMLREADER_DESC=		XMLReader support
+XMLRPC_DESC=		XMLRPC-EPI support
+XMLWRITER_DESC=		XMLWriter support
+XSL_DESC=		XSL support (Implies DOM)
+ZIP_DESC=		ZIP support
+ZLIB_DESC=		ZLIB support
+
+OPTIONS_DEFAULT=	CTYPE \
+			DOM \
+			FILTER \
+			HASH \
+			ICONV \
+			JSON \
+			PDO \
+			PDO_SQLITE \
+			PHAR \
+			POSIX \
+			SESSION \
+			SIMPLEXML \
+			SQLITE \
+			SQLITE3 \
+			TOKENIZER \
+			XML \
+			XMLREADER \
+			XMLWRITER
+
 .include <bsd.port.options.mk>
 
-.for opt in ${ALL_OPTIONS}
-.	if defined(WITH_${opt}) && !defined(WITHOUT_${opt})
+.for opt in ${OPTIONS_DEFINE}
+.	if ${PORT_OPTIONS:M${opt}}
 USE_PHP+=	${opt:L}
 .	endif
 .endfor


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206271104.q5RB4RJ4079255>