Date: Thu, 29 Mar 2012 14:07:19 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Cc: doc@FreeBSD.org Subject: [PATCH] porters-handbook: add make readme to testing, document post-deinstall as invalid Message-ID: <1333055239.029442.9900.nullmailer@experts-exchange.com>
next in thread | raw e-mail | index | archive | help
>Submitter-Id: current-users
>Originator: Jason Helfman
>Organization:
>Confidential: no
>Synopsis: [PATCH] porters-handbook: add make readme to testing, document post-deinstall as invalid
>Severity: non-critical
>Priority: low
>Category: docs
>Class: change-request
>Release: FreeBSD 8.2-RELEASE amd64
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
>Description:
make readme should be tested as part of the porting process
post-deinstall is not a vaild target, and should be documented
Port maintainer (doc@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.99_5 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:
--- .patch begins here ---
Index: book.sgml
===================================================================
RCS file: /usr/local/ncvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v
retrieving revision 1.1173
diff -u -r1.1173 book.sgml
--- book.sgml 22 Mar 2012 04:09:20 -0000 1.1173
+++ book.sgml 29 Mar 2012 21:02:50 -0000
@@ -345,6 +345,10 @@
<step>
<para><command>make package</command></para>
</step>
+
+ <step>
+ <para><command>make readme</command></para>
+ </step>
</procedure>
<para>Make sure that there are not any warnings issued in any of
@@ -576,7 +580,9 @@
intended to be changed. If you want to fix the extraction,
fix <maketarget>do-extract</maketarget>, but never ever
change the way <maketarget>extract</maketarget>
- operates!</para>
+ operates! Additionally, the target <maketarget>post-deinstall
+ </maketarget> is invalid and is not run by the ports
+ infrastructure.</para>
</note>
<para>Now that you understand what goes on when the user types
--- .patch ends here ---
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1333055239.029442.9900.nullmailer>