Date: Wed, 21 Nov 2018 22:36:41 +0100 From: Mariusz Zaborski <oshogbo@freebsd.org> To: rgrimes@freebsd.org Cc: Kyle Evans <kevans@freebsd.org>, 0mp@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r340722 - head/lib/libbe Message-ID: <20181121213641.GA54339@x-wing> In-Reply-To: <201811211654.wALGsAPT072769@pdx.rh.CN85.dnsmgr.net> References: <CACNAnaE=78KLnEM1R-EZd_S0Dbqc1dG2O_Drq5CrGUg4cdUuhA@mail.gmail.com> <201811211654.wALGsAPT072769@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 21, 2018 at 08:54:10AM -0800, Rodney W. Grimes wrote: > > On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes > > <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > > > Author: 0mp (ports committer) > > > > Date: Wed Nov 21 11:22:44 2018 > > > > New Revision: 340722 > > > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > > > > > Log: > > > > libbe(3): Put each error value in separate line. > > > > > > > > As requested by a TODO in the source code. > > > > > > > > Reviewed by: bcr > > > > Approved by: krion (mentor, implicit), mat (mentor, implic= it) > > > > Differential Revision: https://reviews.freebsd.org/D18063 > > > > > > Who with a src bit approved the commit to src? > > > > >=20 > > I do want to clarify- bcr approved it in the review (explicitly with > > "... hereby approved!") -- are you mainly pointing out that he failed > > to annotate this properly in the commit, or is doc bit approval for a > > commit to a manpage in src insufficient? >=20 > That is defanitly a bit of a grey area, from reading and re-reading > the commit bit page it is clear that a doc committer can commit > to src documentation, it is not clear if they can approve a commit > by someone else to the src tree, it does say > ""Approved by" from a non-mentored committer > with the appropriate bit" >=20 > It probably would be fine to have said Approved by: bcr. >=20 > I still question what a out of scope commit that is > approved by: (mentor, implicit). I am not even sure > what that means in this context. Have his mentors > said he can commit anything anyplace without them > seeing it? If so then release the mentor/mentee bit > would be more appropriate? >=20 > >=20 > > As an aside, happy to approve any changes to these manpages as the > > current bectl/libbe maintainer for anyone that wants to improve them. > > =3D) >=20 > That defanitly would of been a cleaner path. C'mon guys. Mateusz is doing a great job with documentation - THANK YOU! I would be more outraged that we still didn't appreciate him. Thanks, --=20 Mariusz Zaborski oshogbo//vx | http://oshogbo.vexillium.org FreeBSD committer | https://freebsd.org Software developer | http://wheelsystems.com If it's not broken, let's fix it till it is!!1 --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkD1x0xkJXVVY1Gwf38KEGuLGxWQFAlv1z+QACgkQ38KEGuLG xWQu6RAAlN0swKr+z/eS9xag31ZYazLY/jOtG0Ucdea5ZQ7LsAbd2csTZXf0daJh zaMl8+hlo5jHiDYI9+2VvOuZ0tjmS8QopkJ/BTm+SWi5/ELDVnOsfGkElnwsA6I8 L0+emkpVaCfZVHlYxuhWbb1FvvVztDk31OdmN0gqArUZ5znswJqIOdOEEph6qPnv 2E9RT/mkMKJKDi55b0lwkZ8RbpFmXo5bFUXtq2EwoWaZllXvtlYoxtxHlDHITauh 5E6yhnCk4DhEYfMGCKuF3cHqc1Z8qzPT7NxRaJoXbncVrgKWdfb/ubL2nigkLKyb CLRxqF7VaCnRaAn46J2EsKsoZWjPIijcImIckz/r7s0xy9Jtc52is5TTr5MzGnwR xB9b+iwp6nabjzpiYtHgScME5WDmLH4av0jOTnARic0Mi7eFQ66KYcScgWeSnlh0 4TkGN4yN2Fl8cenMzVaa82sGci5AAxEnffIc6SWTP3U+Nw8W492TNv+txvWkjsL4 L+mUqzIjxYjLtkucR/r3/3o1j5RYcmlT3cAM+Qu75nLviMxcwEg4yQCP8fhsNjji yuMHkx2oDow0yhVDPpeLCazEXzta8LgPer3pqZcXg38LWuaYvyh2OQh8AO5YwQCF gnF9qzG76BgKOmFpj6w0HSk/GdE5Kp2B1BJNXDfwS1NEDP9mDxk= =4BEr -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181121213641.GA54339>