Date: Mon, 14 Oct 2013 23:52:25 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: Chris Rees <crees@bayofrum.net> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, ports-committers <ports-committers@freebsd.org>, Jason Helfman <jgh@freebsd.org>, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>, "pgsql@FreeBSD.org" <pgsql@freebsd.org> Subject: Re: svn commit: r329946 - in head/databases: postgresql84-client postgresql84-contrib postgresql84-docs postgresql84-server postgresql90-client postgresql90-contrib postgresql90-docs postgresql90-plper... Message-ID: <CAMuy=%2Bi-=Wcm2r67f0pR3R%2BTM8arQtqdT_rfBWUsFxNzKWfVjg@mail.gmail.com> In-Reply-To: <7325bc9d-a492-4b96-b9dc-3a3f8ecbcf3b.maildroid@localhost> References: <201310100009.r9A09Zah023159@svn.freebsd.org> <CAMHz58SsL9LQP1WYzdR_q2fLYjeOkGMy4nc_QJvXj7K8yxy4AA@mail.gmail.com> <7325bc9d-a492-4b96-b9dc-3a3f8ecbcf3b.maildroid@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
Looks good to me, as well, and approved. The port was highly reliant on
PKGNAMESUFFIX changing before, however this is no longer the case.
Thanks!
-jgh
On Sat, Oct 12, 2013 at 12:09 PM, Chris Rees <crees@bayofrum.net> wrote:
> Looks fine to me, if Jason approves.
>
> Thanks also for the Python changes.
>
> Chris
>
>
>
> -----Original Message-----
> From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> To: Jason Helfman <jgh@freebsd.org>, pgsql@freebsd.org
> Cc: ports-committers <ports-committers@freebsd.org>,
> svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
> Sent: Sat, 12 Oct 2013 19:55
> Subject: Re: svn commit: r329946 - in head/databases: postgresql84-client
> postgresql84-contrib postgresql84-docs postgresql84-server
> postgresql90-client postgresql90-contrib postgresql90-docs
> postgresql90-plper...
>
> Hi Jason and pgsql@ team,
>
> May I suggest to remove DISTV as it's only used in PKGNAMESUFFIX and
> portlint complains [1].
> I have prepared a patch [2] which contains 2 changes:
> 1) PKGNAMESUFFIX?=${DISTVERSION:R:S/.//}${COMPONENT}
> 2) Convert to new LIB_DEPENDS format for postgresql*-contrib ports
> I have also checked PKGNAME is unchanged after applying this patch.
> Please review it.
> Thanks.
>
> [1] FATAL: Makefile: extra item "DISTV" placed in the PORTNAME section.
> [2] http://people.freebsd.org/~sunpoet/postgresql-pkgname.patch
>
> Regards,
> sunpoet
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>
--
Jason Helfman | FreeBSD Committer
jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMuy=%2Bi-=Wcm2r67f0pR3R%2BTM8arQtqdT_rfBWUsFxNzKWfVjg>