Date: Wed, 6 Jan 2010 18:40:08 GMT From: Antoine Brodin <antoine@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/142384: sync fsck_msdosfs with OpenBSD Message-ID: <201001061840.o06Ie8B3064569@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/142384; it has been noted by GNATS. From: Antoine Brodin <antoine@FreeBSD.org> To: "Pedro F. Giffuni" <giffunip@tutopia.com> Cc: freebsd-gnats-submit@freebsd.org Subject: Re: bin/142384: sync fsck_msdosfs with OpenBSD Date: Wed, 6 Jan 2010 19:38:06 +0100 On Wed, Jan 6, 2010 at 7:05 PM, Pedro F. Giffuni <giffunip@tutopia.com> wrote: >> This does not look right, you probably want: >> if ((n = read(dosfs, block, sizeof(block))) == -1 || n != sizeof(block)) >> > > Hmm... It was taken as-is from OpenBSD's CVS > > http://www.openbsd.org/cgi-bin/cvsweb/src/sbin/fsck_msdos/boot.c.diff?r1=1.12;r2=1.13 > > but I have no objection with adding the parenthesis. My problem was with the parenthesis between "n=" and "read" in your patch. Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001061840.o06Ie8B3064569>