Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Jul 2018 13:09:00 -0400
From:      Shawn Webb <shawn.webb@hardenedbsd.org>
To:        Brad Davis <brd@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk
Message-ID:  <20180726170900.twg3qeh34wmaerul@mutt-hbsd>
In-Reply-To: <201807261705.w6QH5Y1D034822@repo.freebsd.org>
References:  <201807261705.w6QH5Y1D034822@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--t767piocp6ckdx67
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 26, 2018 at 05:05:34PM +0000, Brad Davis wrote:
> Author: brd
> Date: Thu Jul 26 17:05:33 2018
> New Revision: 336744
> URL: https://svnweb.freebsd.org/changeset/base/336744
>=20
> Log:
>   Convert bsd.files.mk to support DIRS and simplify by only having one in=
stall
>   target.
>  =20
>   Also update the pfctl tests Makefile to work with this change.
>  =20
>   Approved by:	bapt (mentor)
>   Differential Revision:	https://reviews.freebsd.org/D16430
>=20
> Modified:
>   head/sbin/pfctl/tests/files/Makefile
>   head/share/mk/bsd.files.mk
>=20
> Modified: head/sbin/pfctl/tests/files/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sbin/pfctl/tests/files/Makefile	Thu Jul 26 16:51:23 2018	(r33674=
3)
> +++ head/sbin/pfctl/tests/files/Makefile	Thu Jul 26 17:05:33 2018	(r33674=
4)
> @@ -4,9 +4,7 @@ TESTSDIR=3D	${TESTSBASE}/sbin/pfctl/files
>  BINDIR=3D		${TESTSDIR}
> =20
>  # We use ${.CURDIR} as workaround so that the glob patterns work.
> -FILES=3D		${.CURDIR}/pf????.in
> -FILES+=3D		${.CURDIR}/pf????.include
> -FILES+=3D		${.CURDIR}/pf????.ok
> +FILES!=3D		echo ${.CURDIR}/pf????.in ${.CURDIR}/pf????.include ${.CURDIR=
}/pf????.ok

Should this use ${ECHO} instead of echo?

Thanks,

--=20
Shawn Webb
Cofounder and Security Engineer
HardenedBSD

Tor-ified Signal:    +1 443-546-8752
Tor+XMPP+OTR:        lattera@is.a.hacker.sx
GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE

--t767piocp6ckdx67
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAltaACsACgkQaoRlj1JF
bu7+tw/9H0Ij3KoYc2jiRLZNZaMnixhkhYbVOP8I0/u7kWjIzxIECfcivHtdxo68
XojO+kdeKfjC+yjOmsZGUdOa8ZGmSRIVRbTYKTx4dyn06/9GJJVhiyhOlLsI8ra5
QggjQZ0dL0WYyhr4FdG6ys242gFDp4VAFaOpfzN/vzZCENIZ1DmUIjx7B+Cf8MIS
OHPqGkz3KRkAIaQ2tKPQsCrcPaOpSzO1JbTfX21uH258sGLQ7hYRAVSKzIFXNKOk
jGuh1ILJKTBk5gG4y73IqLVuj0YU/0GAYFq6I7ZZdDm9/IJ2mLNBfNizaLYrt0s9
jqLUjKoxhRXlX8eFEI7HpuUS3dZ8QANibyMeI6VPsFvVIydI7ihFyz/DIFin4Pwi
g8OCbrT6yrftgGNPL1U8mKaQ8m/c4jA4AzPobWHskkw667s3CI2oAVCKw3/VXRpW
ZpBxmrHYaGeyMTjvgAc50J6/689H1LE3kQemMvOw1rKP78ND9Qq/q62zXKL52qsO
x5ntE3EoAJfIQvIOH1BJ/BDd156sUxLbqW/VBTjJik3E18Hypj+4BgThuT41ukRt
VV4ETOS8nTQZpQnJZBCdL8+09CjhVq8aYbLuetn+NP5xn5y6bTn8gm68PxPNyHwA
dscBlxDuot87kOuZ1tyCqyoVbBxzEhU6b2eSrfnAU5wc92jp5zo=
=dCHd
-----END PGP SIGNATURE-----

--t767piocp6ckdx67--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180726170900.twg3qeh34wmaerul>