Date: Wed, 1 Sep 2021 11:48:02 -0600 From: Warner Losh <imp@bsdimp.com> To: Craig Leres <leres@freebsd.org> Cc: Ian Lepore <ian@freebsd.org>, FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: Patched gpsd and /dev/pps0 results in "sleeping thread" kernel panic Message-ID: <CANCZdfrJ=PaMg31isWOnd%2BxYwuxLFFW%2BKfdyAVNLnHnf%2B9u2hw@mail.gmail.com> In-Reply-To: <24848efe-aee7-8fe2-9437-005a854a3525@freebsd.org> References: <dc4c4948-738e-c530-d96f-ade5cce5d3d2@freebsd.org> <CANCZdfos2NamQXXcjYyVAcJvUL21kQbjUR4KRTp1xXKsQN3SrA@mail.gmail.com> <5476ea21-9e8a-32f5-08ff-add46c02d910@freebsd.org> <CANCZdfoQTfWC4j=ArTdGQMwDDNsg-LMMYSrtF4BHtHZSuV%2BCkw@mail.gmail.com> <cd29114478b51ca577308dfaacd9df076813a313.camel@freebsd.org> <CANCZdfrkg9dKKoLqpEX285eYPspciNj2eeH8RVZEtAr9Nc1SBQ@mail.gmail.com> <CANCZdfrDsEotO36eE%2BUUvUxAWq=_3pQ9NivGU=_r=%2BikWdUQXw@mail.gmail.com> <5d812d36e5291af35ecadf910a6d5f76b60f1441.camel@freebsd.org> <24848efe-aee7-8fe2-9437-005a854a3525@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000009bbae905caf2aba2 Content-Type: text/plain; charset="UTF-8" On Wed, Sep 1, 2021 at 11:28 AM Craig Leres <leres@freebsd.org> wrote: > On 9/1/21 8:07 AM, Ian Lepore wrote: > > Warner, I pointed out a small change needed to your proposed patch in > > D31763. > > I was able to figure out what to change and am happy to report that it > solves the kernel panic; thanks! Now I'm back to only fighting with gpsd. > That patch looks good to me. I'll update the phab here in a few minutes. > Are the other calls to pps_init() ok? > > steel 183 # find . -name '*.c' | xargs fgrep -w pps_init > ./dev/sio/sio.c: pps_init(&com->pps); > ./i386/i386/elan-mmcr.c: pps_init(&elan_pps); > ./kern/kern_tc.c:pps_init(struct pps_state *pps) > ./kern/kern_tc.c: pps_init(pps); > > I've attached my working version of the patch. > Great! Thanks for testing. sio.c and elan-mmcr.c are likely not worth updating since they are quite old (sio.c has been removed from main, and the elan CPU is little-used with -current). The Elan was from the late 90s or early 2000s, give or take, and designs have moved on since it went EOL over a decade ago. I got rid of my old gear based on that years ago as well, so I can't easily test it. The kern_tc.c file is fine. Warner --0000000000009bbae905caf2aba2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrJ=PaMg31isWOnd%2BxYwuxLFFW%2BKfdyAVNLnHnf%2B9u2hw>