Date: Thu, 19 May 2016 21:02:56 +0300 From: "Andriy Voskoboinyk" <s3erios@gmail.com> To: "Adrian Chadd" <adrian.chadd@gmail.com> Cc: "Don Lewis" <truckman@freebsd.org>, "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org> Subject: Re: minor array overflow in ifconfig set80211chanlist() Message-ID: <op.yhp1q6v7iew4ia@localhost> In-Reply-To: <op.yhksz7c44dikkl@localhost> References: <201605162142.u4GLgs8d072880@gw.catspoiler.org> <op.yhkssoeniew4ia@localhost> <CAJ-VmokTDO9=ZX5rGT1ZtW2aBEvzB_EVpEZvL7crs-KrQmqVMA@mail.gmail.com> <op.yhksz7c44dikkl@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
Tue, 17 May 2016 01:05:57 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Andriy Voskoboinyk = <avos@freebsd.org>: > Tue, 17 May 2016 01:03:03 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Adrian Chadd = > <adrian.chadd@gmail.com>: > >> Heh, god, it's used for both maximum ieee channel number /and/ the >> array size? we should eventually fix that; 11ac channels will likely >> overflow all of the above. :( > > No (yes) :) > I mean ic->ic_nchans and nitems(ic->ic_channels) > ... but you are right: ic_ieee is uint8_t, so it's limited by this = > number too. > ... but there is another macro with the same value: ieee80211_scan_sta.c: #define MAX_IEEE_CHAN 256 /* max acceptable IEEE chan # */ CTASSERT(MAX_IEEE_CHAN >=3D 256); >> >> >> >> -a >> _______________________________________________ >> freebsd-wireless@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-wireless >> To unsubscribe, send any mail to = >> "freebsd-wireless-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to = > "freebsd-wireless-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.yhp1q6v7iew4ia>