Date: Sat, 6 Jan 2001 23:39:35 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Alexander Langer <alex@big.endian.de> Cc: Jeroen Ruigrok van der Werven <asmodai@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/s3 Makefile Message-ID: <Pine.BSF.4.21.0101062324140.18823-100000@besplex.bde.org> In-Reply-To: <20010106125323.A2966@cichlids.cichlids.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 6 Jan 2001, Alexander Langer wrote: > Thus spake Jeroen Ruigrok van der Werven (asmodai@FreeBSD.org): > > > We don't use += for SRCS in Makefiles, we simply use the > > line continuation character and state the rest of the sourcefiles > > on the next line. > > Uhm: > alex:/sys/modules $ grep 'SRCS[^\t ]+=' */Makefile | wc -l > 38 Correcting the pattern to 'SRCS[ ]*+=' (hard tab in this) gives a count of 127. These are mostly style bugs, although not as bad as non-null whitespace between variables and assignment operators (the bad example of modules/fxp/Makefile seems to have been cloned all over). `+=' may be right for separating logically diferent parts of SRCS, e.g., generated header files from non-generated .c files. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0101062324140.18823-100000>