Date: Sat, 7 Apr 2007 20:40:22 +0400 From: Andrey Chernov <ache@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include stdio.h src/sys/sys unistd.h Message-ID: <20070407164022.GA10309@nagual.pp.ru> In-Reply-To: <200704071602.l37G2V1c066806@repoman.freebsd.org> References: <200704071602.l37G2V1c066806@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 07, 2007 at 04:02:31PM +0000, Pawel Jakub Dawidek wrote: > - Only define SEEK_DATA and SEEK_HOLE in sys/unistd.h when neither > _POSIX_SOURCE nor _XOPEN_SOURCE is defined. 1) This new addition should be exluded for !define(_C99_SOURCE) !define(_ANSI_SOURCE) !define(_POSIX_C_SOURCE) too. 2) We design our *_VISIBLE framework right for the reason to not mention all possible *_SOURCE each time like this, making includes unnecessary big and hard to adapt to the future *_SOURCE tags, but mention one *_VISIBLE tag instead, so please rewrite this thing using it. -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070407164022.GA10309>