Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Jan 2002 13:39:06 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        David Malone <dwmalone@maths.tcd.ie>
Cc:        Daniel Eischen <eischen@pcnet1.pcnet.com>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: src/usr.sbin/syslogd syslogd.c 
Message-ID:  <20020110132625.B10617-100000@gamplex.bde.org>
In-Reply-To: <200201092212.aa66829@salmon.maths.tcd.ie>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 9 Jan 2002, David Malone wrote:

> > CVSup'd last night.  I removed the obj tree last week and it
> > didn't work then either.  My /etc/make.conf has
> > CFLAGS= -O -pipe -Wall.

-Wall gives you a nonstandard environment and basically breaks the
control of warnings and errors using WARNS.

> This might be the problem. If the CFLAGS from make.conf end up in
> the final CFLAGS after the -Wno-uninitialized from bsd.sys.mk, as
> it reenableles checking for uninitialised variables. This may break
> things in directories where WARNS are enabeled.

The problem here is that WARNS defaults to 1 for syslogd, so
-Wno-uninitialized doesn't get set (because bsd.sys.mk doesn't set anything
that would sets -Wuninitialized), but -Werror gets set (because that is
what WARNS=1 asks for).  -Werror in combination with -Wall tends to be
fatal in code that has not been Wallified.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020110132625.B10617-100000>