Date: Thu, 06 Jun 2002 20:39:20 -0600 (MDT) From: "M. Warner Losh" <imp@village.org> To: gallatin@cs.duke.edu Cc: des@ofug.org, alpha@freebsd.org, current@freebsd.org Subject: Re: alpha can't map interrupt Message-ID: <20020606.203920.128346019.imp@village.org> In-Reply-To: <15616.3530.526275.555196@grasshopper.cs.duke.edu> References: <xzp660vrjbj.fsf@flood.ping.uio.no> <15616.3530.526275.555196@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Please accept my appologies for this, it does look like I messed up the MI code. The following change may mess up the pcib code a little, but I think that the MD code now does the right thing. Does this fix things for you? Warner Index: pcivar.h =================================================================== RCS file: /cache/ncvs/src/sys/dev/pci/pcivar.h,v retrieving revision 1.56 diff -u -r1.56 pcivar.h --- pcivar.h 1 Jun 2002 05:40:33 -0000 1.56 +++ pcivar.h 7 Jun 2002 02:35:52 -0000 @@ -246,10 +246,12 @@ #undef PCIB_ACCESSOR /* - * PCI interrupt validation. + * PCI interrupt validation. Invalid interrupt values such as 0 or 128 + * on i386 or other platforms should be mapped out in the MD pcireadconf + * code and not here, since the only MI invalid IRQ is 255. */ #define PCI_INVALID_IRQ 255 -#define PCI_INTERRUPT_VALID(x) (((x) != 0) && ((x) != PCI_INVALID_IRQ)) +#define PCI_INTERRUPT_VALID(x) ((x) != PCI_INVALID_IRQ) /* * Convenience functions. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020606.203920.128346019.imp>