Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 May 2021 16:20:45 GMT
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 68d311b66678 - main - ptracestop: mark threads suspended there with the new TDB_SSWITCH flag
Message-ID:  <202105031620.143GKjRQ022348@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=68d311b66678d9daffc5cf1c78f3101f2eeec3ea

commit 68d311b66678d9daffc5cf1c78f3101f2eeec3ea
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-04-24 12:02:40 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-05-03 16:18:25 +0000

    ptracestop: mark threads suspended there with the new TDB_SSWITCH flag
    
    This way threads in ptracestop can be discovered by debugger
    
    Reviewed by:    markj
    Tested by:      pho
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 week
    Differential revision:  https://reviews.freebsd.org/D29955
---
 sys/kern/kern_sig.c | 2 ++
 sys/sys/proc.h      | 1 +
 2 files changed, 3 insertions(+)

diff --git a/sys/kern/kern_sig.c b/sys/kern/kern_sig.c
index 46b520030dcd..445582a176c8 100644
--- a/sys/kern/kern_sig.c
+++ b/sys/kern/kern_sig.c
@@ -2648,7 +2648,9 @@ ptracestop(struct thread *td, int sig, ksiginfo_t *si)
 				td->td_dbgflags &= ~TDB_STOPATFORK;
 			}
 stopme:
+			td->td_dbgflags |= TDB_SSWITCH;
 			thread_suspend_switch(td, p);
+			td->td_dbgflags &= ~TDB_SSWITCH;
 			if (p->p_xthread == td)
 				p->p_xthread = NULL;
 			if (!(p->p_flag & P_TRACED))
diff --git a/sys/sys/proc.h b/sys/sys/proc.h
index e02e97d74229..b959681e992b 100644
--- a/sys/sys/proc.h
+++ b/sys/sys/proc.h
@@ -485,6 +485,7 @@ do {									\
 #define	TDB_VFORK	0x00000800 /* vfork indicator for ptrace() */
 #define	TDB_FSTP	0x00001000 /* The thread is PT_ATTACH leader */
 #define	TDB_STEP	0x00002000 /* (x86) PSL_T set for PT_STEP */
+#define	TDB_SSWITCH	0x00004000 /* Suspended in ptracestop */
 
 /*
  * "Private" flags kept in td_pflags:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105031620.143GKjRQ022348>