Date: Sat, 12 Jan 2002 18:13:25 -0800 From: Alfred Perlstein <bright@mu.org> To: John Baldwin <jhb@FreeBSD.org> Cc: smp@freebsd.org, dillon@freebsd.org, tanimura@freebsd.org Subject: Re: fd locking. Message-ID: <20020112181325.I7984@elvis.mu.org> In-Reply-To: <XFMail.020112180231.jhb@FreeBSD.org>; from jhb@FreeBSD.org on Sat, Jan 12, 2002 at 06:02:31PM -0800 References: <XFMail.020112174456.jhb@FreeBSD.org> <XFMail.020112180231.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* John Baldwin <jhb@FreeBSD.org> [020112 18:03] wrote: > > On 13-Jan-02 John Baldwin wrote: > > > > On 13-Jan-02 Alfred Perlstein wrote: > >> * Alfred Perlstein <bright@mu.org> [020112 03:11] wrote: > >>> I've got world building with these patches. > >>> > >>> http://people.freebsd.org/~alfred/fd.diff > >>> > >>> or > >>> > >>> http://people.freebsd.org/~alfred/fd.diff.gz > >> > >> I've been asked for an archetectural overview. > > One bug: > > --- compat/svr4/svr4_fcntl.c 2001/09/12 08:36:58 > +++ compat/svr4/svr4_fcntl.c 2002/01/08 08:39:08 > @@ -341,7 +349,10 @@ > SCARG(&ft, fd) = fd; > SCARG(&ft, length) = start; > > - return ftruncate(td, &ft); > + error = ftruncate(p, &ft); > + > + fdrop(fp, td); > + return (error); > } > > int > > ftruncate() takes a thread, not a proc. There's also a bug in dupfdopen(), at about line 1862 there's a superfulous FILE_UNLOCK that i had to remove. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductable donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020112181325.I7984>