Date: Thu, 17 May 2018 14:40:13 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Matthew Macy <mmacy@freebsd.org> Cc: Emmanuel Vadot <manu@bidouilliste.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333745 - in head/sys/contrib/ck: include src Message-ID: <41ae57bd-2c49-97cd-1f46-2644519a95e6@FreeBSD.org> In-Reply-To: <CAPrugNp77ysDN=0AQ4jji3Z_y85tUCVZoVO4hPZ3_1so=8LZ0Q@mail.gmail.com> References: <201805171814.w4HIEA0F079835@repo.freebsd.org> <20180517203856.aa6b8b241e23b9c07483232b@bidouilliste.com> <CAPrugNoX0n3TV90r0AARGSo16=gt2xOidsD17nxBHV1W_jbiuw@mail.gmail.com> <17058056-6b70-e918-dab8-63951d1bfbbd@FreeBSD.org> <20180517212757.84c7b02060ca8f86e56dbee9@bidouilliste.com> <11fb642a-d334-bd7d-be4f-b1aa181b8eb2@FreeBSD.org> <CAPrugNp77ysDN=0AQ4jji3Z_y85tUCVZoVO4hPZ3_1so=8LZ0Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17/05/2018 14:35, Matthew Macy wrote: > On Thu, May 17, 2018 at 12:32 PM, Pedro Giffuni <pfg@freebsd.org> wrote: >> >> On 17/05/2018 14:27, Emmanuel Vadot wrote: >>> On Thu, 17 May 2018 14:20:05 -0500 >>> Pedro Giffuni <pfg@FreeBSD.org> wrote: >>> >>>> On 17/05/2018 14:12, Matthew Macy wrote: >>>>> How do I avoid problems while allowing timely updates? >>>>> >>>>> -M >>>>> >>>>> On Thu, May 17, 2018 at 11:38 AM, Emmanuel Vadot <manu@bidouilliste.com> >>>>> wrote: >>>>>> Hi Matt, >>>>>> >>>>>> On Thu, 17 May 2018 18:14:10 +0000 (UTC) >>>>>> Matt Macy <mmacy@FreeBSD.org> wrote: >>>>>> >>>>>>> Author: mmacy >>>>>>> Date: Thu May 17 18:14:10 2018 >>>>>>> New Revision: 333745 >>>>>>> URL: https://svnweb.freebsd.org/changeset/base/333745 >>>>>>> >>>>>>> Log: >>>>>>> ck: add support for executing callbacks outside of main poll loop >>>>>>> >>>>>>> Pull in change from upstream >>>>>>> deca119d14bfffd440770eb67cbdbeaf7b57eb7b >>>>>>> >>>>>>> | ck_epoch: introduce ck_epoch_deferred >>>>>>> | >>>>>>> | Allow for deferral to occur outside epoch poll critical loop >>>>>>> (which may access per-CPU structures). >>>>>>> | >>>>>>> >>>>>>> Approved by: sbruno >>>>>>> >>>>>>> Modified: >>>>>>> head/sys/contrib/ck/include/ck_epoch.h >>>>>>> head/sys/contrib/ck/src/ck_epoch.c >>>>>>> >>>>>> CK was imported in vendor-sys/ck, commiting directly into head will >>>>>> cause some problems in the future. >>>> Actually ... committing to head is fine: some things just have to be >>>> fixed. >>> This is not true, it can cause a lot of problems with futures updates >>> if the change isn't in the vendor repo. >> OK ... I meant generally you can. The catch here is that the change was >> already upstream so it should have been done in the vendor area and then >> merged. It's best to fix this properly now. >> >> Sorry for misguiding. >> > I'm happy to comply - just point me at the fine manual. > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/subversion-primer.html Section 5.4.4 (Vendor patches). Cheers, Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41ae57bd-2c49-97cd-1f46-2644519a95e6>