Date: Mon, 3 Jun 2013 21:48:23 GMT From: Rene Ladan <rene@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/179275: multimedia/banshee: remove (disabled) boo support Message-ID: <201306032148.r53LmNhl032022@oldred.freebsd.org> Resent-Message-ID: <201306032150.r53Lo03Y046156@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 179275
>Category: ports
>Synopsis: multimedia/banshee: remove (disabled) boo support
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Jun 03 21:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Rene Ladan
>Release: FreeBSD 9.1-amd64
>Organization:
>Environment:
multimedia/banshee @ r317503, ports @ r319807
>Description:
There is a disabled option for Boo support in multimedia/banshee, but lang/boo is broken and expired. Fully remove Boo support to allow lang/boo to be removed.
While here pet portlint and fix the MPT option.
>How-To-Repeat:
`Tools/scripts/rmport lang/boo` finds this port as a dependent one.
>Fix:
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 319807)
+++ Makefile (working copy)
@@ -22,14 +22,13 @@
${LOCALBASE}/libdata/pkgconfig/mono-addins.pc:${PORTSDIR}/devel/mono-addins \
${LOCALBASE}/libdata/pkgconfig/notify-sharp.pc:${PORTSDIR}/devel/notify-sharp
-# For now, remove APPLEDEV and BOO since they are broken
+# For now, remove APPLEDEV since it is broken
OPTIONS_DEFINE= DOCS BPMDETECT GIO MTP WEBKIT YOUTUBE
APPLEDEV_DESC= Apple device
-BOO_DESC= Boo
BPMDETECT_DESC= Force dependency on soundtouch (required for BPM detection)
GIO_DESC= Use GIO for disk access
-WEBKIT_DESC= Build and/or install extensions using Webkit
+WEBKIT_DESC= Build and/or install extensions using Webkit
YOUTUBE_DESC= Build and/or install the Youtube extension
OPTIONS_DEFAULT=BPMDETECT GIO MTP WEBKIT YOUTUBE
@@ -45,7 +44,7 @@
USE_SQLITE= yes
INSTALLS_ICONS= yes
CONFIGURE_TARGET= --build=${ARCH}-portbld-freebsd${OSREL}
-CONFIGURE_ARGS= --with-vendor-build-id=FreeBSD\ BSD\#\ Project --disable-gio-hardware
+CONFIGURE_ARGS= --with-vendor-build-id=FreeBSD\ BSD\#\ Project --disable-gio-hardware --disable-boo
.include <bsd.port.options.mk>
@@ -83,16 +82,6 @@
USE_GSTREAMER+= soundtouch
.endif
-.if ${PORT_OPTIONS:MBOO}
-CONFIGURE_ARGS+=--enable-boo
-BUILD_DEPENDS+= booc:${PORTSDIR}/lang/boo
-RUN_DEPENDS+= booc:${PORTSDIR}/lang/boo
-PLIST_SUB+= OPT_BOO=""
-.else
-CONFIGURE_ARGS+=--disable-boo
-PLIST_SUB+= OPT_BOO="@comment "
-.endif
-
.if ${PORT_OPTIONS:MAPPLEDEV}
CONFIGURE_ARGS+=--enable-appledevice
LIB_PC_DEPENDS+=${LOCALBASE}/libdata/pkgconfig/libgpodsharp.pc:${PORTSDIR}/audio/libgpod
@@ -103,7 +92,7 @@
PLIST_SUB+= APPLEDEV="@comment "
.endif
-.if ${PORTSDIR:MMTP}
+.if ${PORT_OPTIONS:MMTP}
CONFIGURE_ARGS+=--enable-mtp
LIB_DEPENDS+= mtp:${PORTSDIR}/audio/libmtp
PLIST_SUB+= OPT_MTP=""
Index: pkg-plist
===================================================================
--- pkg-plist (revision 319807)
+++ pkg-plist (working copy)
@@ -49,8 +49,6 @@
lib/banshee/Extensions/Banshee.AmazonMp3.exe.mdb
lib/banshee/Extensions/Banshee.Audiobook.dll
lib/banshee/Extensions/Banshee.Audiobook.dll.mdb
-%%OPT_BOO%%lib/banshee/Extensions/Banshee.BooScript.dll
-%%OPT_BOO%%lib/banshee/Extensions/Banshee.BooScript.dll.mdb
lib/banshee/Extensions/Banshee.Bpm.dll
lib/banshee/Extensions/Banshee.Bpm.dll.mdb
lib/banshee/Extensions/Banshee.CoverArt.dll
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306032148.r53LmNhl032022>