Date: Fri, 25 Mar 2011 18:53:14 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: "Pedro F. Giffuni" <giffunip@tutopia.com> Cc: freebsd-fs@freebsd.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD Message-ID: <20110325165314.GO78089@deviant.kiev.zoral.com.ua> In-Reply-To: <201103251610.p2PGAFOb063448@freefall.freebsd.org> References: <201103251610.p2PGAFOb063448@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--p2phRCRr7PirLLhx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 25, 2011 at 04:10:15PM +0000, Pedro F. Giffuni wrote: > The following reply was made to PR kern/152079; it has been noted by GNAT= S. >=20 > From: "Pedro F. Giffuni" <giffunip@tutopia.com> > To: bug-followup@FreeBSD.org > Cc: =20 > Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other= NetBSD/OpenBSD > Date: Fri, 25 Mar 2011 09:09:04 -0700 (PDT) >=20 > --0-691748129-1301069344=3D:71034 > Content-Type: text/plain; charset=3Dus-ascii > =20 > Include a small fix from NetBSD: > =20 > msdosfs_vnops.c Revision 1.73: > Remove a vnode reference leak from msdosfs_rename. Release tdvp if either > doscheckpath() or relookup() fails. > =20 > Adjust test fs/vfs/t_vnops.c and remove the link count test for msdos. > =20 > Fixes NetBSD PR #44661 Can you extract the test referenced in the commit message ? I think that s/EROFS/EINVAL/ change could and should be committed first, and then the (potential) fix for the vnode leakage as a separate commit. --p2phRCRr7PirLLhx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk2MyHoACgkQC3+MBN1Mb4gGQwCfSQKDH2YijpLy6YYC3o/ArYU/ 6ygAnjvoPU4c77LiJTYUx+3eKoWRNq1p =g0+4 -----END PGP SIGNATURE----- --p2phRCRr7PirLLhx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110325165314.GO78089>