Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Jan 2013 18:57:13 +1100 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        svn-src-projects@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r245771 - in projects/counters/sys: kern sys
Message-ID:  <20130122184626.W1395@besplex.bde.org>
In-Reply-To: <201301220622.r0M6MfWW038329@svn.freebsd.org>
References:  <201301220622.r0M6MfWW038329@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 22 Jan 2013, Gleb Smirnoff wrote:

> Log:
>  Remove namespace pollution.
>
>  Noticed by:	bde
>
> Modified:
>  projects/counters/sys/kern/subr_counter.c
>  projects/counters/sys/sys/counter.h
>
> ...
> Modified: projects/counters/sys/sys/counter.h
> ==============================================================================
> --- projects/counters/sys/sys/counter.h	Tue Jan 22 06:21:44 2013	(r245770)
> +++ projects/counters/sys/sys/counter.h	Tue Jan 22 06:22:40 2013	(r245771)
> @@ -29,9 +29,6 @@
> #ifndef __SYS_COUNTER_H__
> #define __SYS_COUNTER_H__
>
> -#include <sys/param.h>
> -#include <sys/systm.h>
> -
> typedef uint64_t *counter_u64_t;
>
> #include <machine/counter.h>

Thanks.

There are several other headers in <sys> in -current that include sys/param.h:

 	acl.h:#include <sys/param.h>
 	fail.h:#include <sys/param.h>
 	ktr.h:#include <sys/param.h>
 	malloc.h:#include <sys/param.h>
 	pmckern.h:#include <sys/param.h>
 	posix4.h:#include <sys/param.h>
 	procfs.h:#include <sys/param.h>
 	ptrace.h:#include <sys/param.h>
 	tty.h:#include <sys/param.h>

In FreeBSD-[3-5], procfs.h was the only one of these.  posix4.h also had it,
but wasn't in <sys>.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130122184626.W1395>