Date: Wed, 10 Mar 2021 19:39:34 +0100 From: Olivier Houchard <cognet@ci0.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Olivier Houchard <cognet@freebsd.org>, John Baldwin <jhb@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: c328f64d8107 - main - arm64: Fix COMPAT_FREEBSD32. Message-ID: <YEkSZqiDuozeMgsh@ci0.org> In-Reply-To: <28B50FA6-65E4-4A5A-8339-8A4A8720974B@freebsd.org> References: <202103101807.12AI7IVW089870@gitrepo.freebsd.org> <28B50FA6-65E4-4A5A-8339-8A4A8720974B@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Jessica, On Wed, Mar 10, 2021 at 06:36:35PM +0000, Jessica Clarke wrote: > On 10 Mar 2021, at 18:07, Olivier Houchard <cognet@FreeBSD.org> wrote: > > > > The branch main has been updated by cognet: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=c328f64d81079bad5064c8a387883df50ab5aaed > > > > commit c328f64d81079bad5064c8a387883df50ab5aaed > > Author: Olivier Houchard <cognet@FreeBSD.org> > > AuthorDate: 2021-03-10 18:01:41 +0000 > > Commit: Olivier Houchard <cognet@FreeBSD.org> > > CommitDate: 2021-03-10 18:06:42 +0000 > > > > arm64: Fix COMPAT_FREEBSD32. > > > > The ENTRY() macro was modified by commit > > 28d945204ea1014d7de6906af8470ed8b3311335 to add an optional NOP instruction > > at the beginning of the function. It is of course an arm64 instruction, so > > unsuitable for the 32bits sigcode. So just use EENTRY() instead for > > aarch32_sigcode. This should fix receiving signals when running 32bits > > binaries on FreeBSD/arm64. > > Hmm, that's a good point, does the extra nop for the AArch64 sigcode > cause issues for gdb detecting it? > > Perhaps we should upstream CheriBSD's SIGCODE macros?.. > I wondered about that, but decided not to dig that rabbit hole :) Having specific macros would certainly make sense. Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YEkSZqiDuozeMgsh>