Date: Wed, 02 Aug 2006 03:37:05 +0000 From: "Qing Li" <qingli@speakeasy.net> To: "Yar Tikhiy" <yar@FreeBSD.org>, "Qing Li" <qingli@FreeBSD.org> Cc: cvs-src@FreeBSD.org, sam@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c Message-ID: <W89695191110071154489825@webmail2>
next in thread | raw e-mail | index | archive | help
> > Removing the "dead" assignment to evl->evl_encap_proto above and > reducing the bcopy window by 2 bytes here is a nano-optimization. > Which is worse, it smuggles hidden dot1q details in this otherwise > encapsulation-neutral block of code. E.g., I could use the former > code for both dot1q and ISL privately by just redefining > ETHER_VLAN_ENCAP_LEN. > You are right. > > Grand total: I would greately appreciate if you backed out this > change and then fixed the tag value of -1 alone, but let me review > that first. Thanks! > Okay. Thanks, -- Qing
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?W89695191110071154489825>