Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Nov 2001 20:02:03 -0800
From:      John Merryweather Cooper <john_m_cooper@yahoo.com>
To:        clefevre@citeweb.net
Cc:        Maxim Sobolev <sobomax@FreeBSD.org>, Will Andrews <will@physics.purdue.edu>, Mario Sergio Fujikawa Ferreira <lioux@uol.com.br>, Thomas Gellekum <tg@FreeBSD.org>, freebsd-ports@FreeBSD.org, portmgr@FreeBSD.org
Subject:   Re: cvs commit: ports/Mk bsd.port.mk
Message-ID:  <20011115200203.M33074@johncoop.MSHOME>
In-Reply-To: <200111160338.fAG3cP213471@gits.dyndns.org>; from clefevre@citeweb.net on Thu, Nov 15, 2001 at 19:38:25 -0800
References:  <3BF40798.7F66C0DD@FreeBSD.org> <200111160338.fAG3cP213471@gits.dyndns.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 2001.11.15 19:38 Cyrille Lefevre wrote:
> Maxim Sobolev wrote:
> [ Charset KOI8-R unsupported, converting... ]
> > Will Andrews wrote:
> > >
> > > On Wed, Nov 14, 2001 at 01:48:33AM -0200, Mario Sergio Fujikawa
> Ferreira wrote:
> > > >       That's sweeeet but what about discussing this one too?
> > > > It was proposed a while ago. :) So that we can automagically
> take
> > > > care of this based on _VER
> > >
> > > Yes, please.
> >
> > This patch is incomplete because it lacks documentation in the
> > comments at the beginning of the file. Please extend it
> appropriately
> > and resubmit. Other than that looks fine to me.
> 
> PS : please, followup to your own PR and don't submit a new one
>      using send-pr. this is a common error...
> 
> Cyrille.
> --
> Cyrille Lefevre                 mailto:clefevre@citeweb.net
> 

Regrettably, it's common because followup appears to be ignored.  There 
are a few instances I can point to with PR's I have submitted where 
this is clearly the case.  :(

-- 
jmc                               ||   MacroHard --                    \
                                   ||       the perfection of form over 
|
----------------------------------||       substance, marketing over   |
Web:  http://www.borgsdemons.com  ||       performance, and greed over |
                                   ||       design . . .                
|
=======================================================================/
Public Key:  http://www.borgsdemons.com/Personal/pgpkey.asc            |
=======================================================================\

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011115200203.M33074>