Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Aug 2019 23:09:12 +0200
From:      Emmanuel Vadot <manu@bidouilliste.com>
To:        Matt Macy <mmacy@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   Re: svn commit: r351103 - stable/12/lib/libpmc
Message-ID:  <20190816230912.bc68b7be072d2d14ca74d7bc@bidouilliste.com>
In-Reply-To: <20190816004618.981a9f7cfb16eed5b026d1d5@bidouilliste.com>
References:  <201908152139.x7FLdMwL094779@repo.freebsd.org> <20190816004618.981a9f7cfb16eed5b026d1d5@bidouilliste.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 16 Aug 2019 00:46:18 +0200
Emmanuel Vadot <manu@bidouilliste.com> wrote:

> On Thu, 15 Aug 2019 21:39:22 +0000 (UTC)
> Matt Macy <mmacy@FreeBSD.org> wrote:
> 
> > Author: mmacy
> > Date: Thu Aug 15 21:39:21 2019
> > New Revision: 351103
> > URL: https://svnweb.freebsd.org/changeset/base/351103
> > 
> > Log:
> >   pmc: restore "unhalted-cycles" alias
> >   
> >   Reported by:	mav@
> > 
> > Modified:
> >   stable/12/lib/libpmc/libpmc_pmu_util.c
> > 
> > Modified: stable/12/lib/libpmc/libpmc_pmu_util.c
> > ==============================================================================
> > --- stable/12/lib/libpmc/libpmc_pmu_util.c	Thu Aug 15 19:52:32 2019	(r351102)
> > +++ stable/12/lib/libpmc/libpmc_pmu_util.c	Thu Aug 15 21:39:21 2019	(r351103)
> > @@ -69,6 +69,7 @@ static struct pmu_alias pmu_intel_alias_table[] = {
> >  	{"BRANCH_MISSES_RETIRED", "BR_MISP_RETIRED.ALL_BRANCHES"},
> >  	{"BRANCH-MISSES-RETIRED", "BR_MISP_RETIRED.ALL_BRANCHES"},
> >  	{"cycles", "tsc-tsc"},
> > +	{"unhalted-cycles", "CPU_CLK_UNHALTED.THREAD_P_ANY"},
> >  	{"instructions", "inst-retired.any_p"},
> >  	{"branch-mispredicts", "br_misp_retired.all_branches"},
> >  	{"branches", "br_inst_retired.all_branches"},
> 
>  Why is this a direct commit to stable/12 and not an MFC of r351104 ?
>  Also you are supposed to wait 3 days to MFC thing.

 ping ?

 Could you at least record the mergeinfo for r351104 this since was
basically mfc'ed ?

-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190816230912.bc68b7be072d2d14ca74d7bc>