Date: Wed, 30 Apr 2008 10:49:19 -0700 From: Sam Leffler <sam@freebsd.org> To: obrien@freebsd.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: CVSROOT exclude Message-ID: <4818B11F.6050609@freebsd.org> In-Reply-To: <20080430174023.GA22190@dragon.NUXI.org> References: <200804292135.m3TLZONF045026@repoman.freebsd.org> <20080430165352.GA89079@dragon.NUXI.org> <4818A559.1010903@freebsd.org> <20080430174023.GA22190@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien wrote:
> On Wed, Apr 30, 2008 at 09:59:05AM -0700, Sam Leffler wrote:
>
>> David O'Brien wrote:
>>
>>> On Tue, Apr 29, 2008 at 09:35:24PM +0000, Sam Leffler wrote:
>>>
>>>> . exclude Log:
>>>> add iwn firmware
>>>>
>>> Hi Sam,
>>> I notice we keep excluding $FreeBSD$ from uuencoded firmware files.
>>> At least looking at sys/contrib/dev/iwn/iwlwifi-4965-4.44.17.fw.uu,
>>> which has a Copyright notice at the top, I think the use of this file
>>> would tolerate a $FreeBSD$ on the first line.
>>>
>>> Would you mind if I fixed this?
>>>
>>>
>> I copied previous practice in excluding the entire directory.
>>
>
> I think "the previous practice" mostly comes from the wireless firmware
> where the folks committing it may not have realized that "$FreeBSD$" will
> be nicely ignored by uudecode.
>
I was involved with placing the other Intel firmware in sys/contrib.
>
>> The issue
>> isn't whether it's possible to insert a keyword but rather whether it's a
>> good idea to alter files (like the LICENSE files) that come directly from
>> "the vendor" under limited terms.
>>
>
> # $FreeBSD: src/sys/contrib/dev/ral/rt2860.fw.uu,v 1.1 2008/04/20 20:35:35 sam Exp $
> (and the other *.uu's there) are examples where we've done it. And I
> think its fine.
>
> Note, if these come straight from a vendor, why aren't they being vendor
> imported?
>
>
If "these" refers to the ralink firmware images they do not come
straight from the vendor; I generated them from the rt2661_ucode.h file
I got from obsd CVS. The LICENSE file in that directory however
could/should be intact but I was lazy; I will correct that.
I'm not opposed to adding a keyword but I don't want to have to go back
through lawyers to get approval. If you want to do all the work be my
guest.
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4818B11F.6050609>