Date: Tue, 10 Jan 2012 23:01:19 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Guy Helmer <guy.helmer@palisadesystems.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r229937 - in head/lib: libc/gen libutil Message-ID: <20120110220119.GD1694@garage.freebsd.pl> In-Reply-To: <A1075E3E-E7F8-43C0-9D15-2524BE6E8ACB@palisadesystems.com> References: <201201101953.q0AJrPao025097@svn.freebsd.org> <20120110214243.GC1694@garage.freebsd.pl> <A1075E3E-E7F8-43C0-9D15-2524BE6E8ACB@palisadesystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--1sNVjLsmu1MXqwQ/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 10, 2012 at 03:52:35PM -0600, Guy Helmer wrote: >=20 > On Jan 10, 2012, at 3:42 PM, Pawel Jakub Dawidek wrote: >=20 > > On Tue, Jan 10, 2012 at 07:53:25PM +0000, Guy Helmer wrote: > >> Author: ghelmer > >> Date: Tue Jan 10 19:53:25 2012 > >> New Revision: 229937 > >> URL: http://svn.freebsd.org/changeset/base/229937 > >>=20 > >> Log: > >> Add pidfile_fileno() to obtain the file descriptor for an open > >> pidfile. > >=20 > > BTW. If you are working on pidfile, it would be nice to move pidfile > > structure declaration into pidfile.c. There is no need to expose it. >=20 >=20 > Is that change likely to require a "make universe" to validate? Nice try:) No, I won't take the responsibility:) Ok, seriously. Nothing should use this structure directly. You will still need forward declaration in pidfile.h. It is not something that is arch-depended, so simple buildworld should be sufficient. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --1sNVjLsmu1MXqwQ/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8MtS8ACgkQForvXbEpPzQEnACghiFdyOr9cR6saokirJh3LqeF pI4Anivt31CKTeHKDVTCZEgKn/4ZE9sg =oa00 -----END PGP SIGNATURE----- --1sNVjLsmu1MXqwQ/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120110220119.GD1694>