Date: Thu, 26 Sep 2002 21:12:49 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Peter Wemm <peter@wemm.org> Cc: current@freebsd.org Subject: Re: alpha tinderbox failure Message-ID: <Pine.BSF.4.21.0209262111360.72301-100000@root.org> In-Reply-To: <20020927001249.D054B2A894@canning.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 26 Sep 2002, Peter Wemm wrote: > Nate Lawson wrote: > > On Thu, 26 Sep 2002, Dag-Erling Smorgrav wrote: > > > >>> Kernel build for LINT started on Thu Sep 26 15:50:41 PDT 2002 > > > -------------------------------------------------------------- > > > ===> vinum > > > cc1: warnings being treated as errors > > > /h/des/src/sys/dev/advansys/adv_pci.c: In function `adv_pci_attach': > > > /h/des/src/sys/dev/advansys/adv_pci.c:197: warning: overflow in implicit co > nstant conversion > > > *** Error code 1 > > > > > > Stop in /h/des/obj/h/des/src/sys/LINT. > > > *** Error code 1 > > > > > > Stop in /h/des/src. > > > *** Error code 1 > > > > > > Stop in /h/des/src. > > > > I don't understand why this error occurs since the types all seem to > > match. > > > > Relevant lines from src/sys/dev/advansys/adv_pci.c: > > > > /* Allocate a dmatag for our transfer DMA maps */ > > /* XXX Should be a child of the PCI bus dma tag */ > > error = bus_dma_tag_create(/*parent*/NULL, /*alignment*/1, > > /*boundary*/0, > > /*lowaddr*/ADV_PCI_MAX_DMA_ADDR, > > /*highaddr*/BUS_SPACE_MAXADDR, > > /*filter*/NULL, /*filterarg*/NULL, > > /*maxsize*/BUS_SPACE_MAXSIZE_32BIT, > > /*nsegments*/BUS_SPACE_UNRESTRICTED, > > /*maxsegsz*/ADV_PCI_MAX_DMA_COUNT, > > /*flags*/0, > > 197 -----> &adv->parent_dmat); > > > > > gcc is telling you the wrong line. The problem is here: > > int nsegments; > vs: > /*nsegments*/BUS_SPACE_UNRESTRICTED, > note that: > bus.h:#define BUS_SPACE_UNRESTRICTED (~0UL) > > 0xffffffffffffffff will not fit in an int. I looked at this some more. Would it be ok to make it (~0) since we'll never need 64 bits worth of nsegments? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0209262111360.72301-100000>