Date: Sun, 6 Jan 2002 22:51:58 +0200 From: Peter Pentchev <roam@ringlet.net> To: arch@FreeBSD.org Cc: Dag-Erling Smorgrav <des@ofug.org>, re@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch Makefile common.c common.h fetch.3 fetch.c fetch.h file.c ftp.c http.c Message-ID: <20020106225158.H314@straylight.oblivion.bg> In-Reply-To: <xzphepzkvye.fsf@flood.ping.uio.no>; from des@ofug.org on Sun, Jan 06, 2002 at 10:31:37PM %2B0100 References: <200112180944.fBI9ioK99527@freefall.freebsd.org> <20011225162803.C304@straylight.oblivion.bg> <20020106222223.F314@straylight.oblivion.bg> <xzphepzkvye.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 06, 2002 at 10:31:37PM +0100, Dag-Erling Smorgrav wrote:
> Peter Pentchev <roam@ringlet.net> writes:
> > This is still an issue: libfetch does not compile on -stable with
> > WARNS_WERROR set. I guess it would not compile on -current, either,
> > was it not for David O'Brien's changing the WARNS granularity, so
> > WARNS=2 is 'mostly harmless' now :)
>
> I know. Read CVS logs. It used to have NO_WERROR in the Makefile,
> but somebody removed it without informing me.
Oh.. oops.. sorry! No, the NO_WERROR is still there in -stable,
the bug is in bsd.sys.mk - the -stable version does not honor NO_WERROR
at all!
Okay then, how about the attached patch to bsd.sys.mk for -stable?
I'm CC'ing this to re@, so they could put in a word or two about
commits to -stable.. IMHO, a bsd.sys.mk bug that breaks the world
build if a (supported) make(1) knob is set should really be considered
a notable bug :)
G'luck,
Peter
--
If there were no counterfactuals, this sentence would not have been paradoxical.
Index: src/share/mk/bsd.sys.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v
retrieving revision 1.3.2.3
diff -u -r1.3.2.3 bsd.sys.mk
--- src/share/mk/bsd.sys.mk 21 Aug 2001 23:04:07 -0000 1.3.2.3
+++ src/share/mk/bsd.sys.mk 6 Jan 2002 20:40:12 -0000
@@ -13,7 +13,7 @@
# XXX Delete -Wuninitialized by default for now -- the compiler doesn't
# XXX always get it right.
CFLAGS += -Wno-uninitialized
-. if defined(WARNS_WERROR)
+. if defined(WARNS_WERROR) && !defined(NO_WERROR)
CFLAGS += -Werror
. endif
. endif
@@ -28,7 +28,7 @@
. if defined(WFORMAT)
. if ${WFORMAT} > 0
CFLAGS += -Wnon-const-format -Wno-format-extra-args
-. if defined(WARNS_WERROR)
+. if defined(WARNS_WERROR) && !defined(NO_WERROR)
CFLAGS += -Werror
. endif
. endif
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020106225158.H314>