Date: Sun, 31 Mar 2013 11:11:26 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Chris Rees <crees@FreeBSD.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, svn-ports-all@freebsd.org, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Joe Marcus Clarke <marcus@freebsd.org>, Niclas Zeising <zeising@freebsd.org>, =?ISO-8859-1?Q?Beat_G=E4tzi?= <beat@freebsd.org> Subject: Re: svn commit: r315624 - head/net/wireshark Message-ID: <5158602E.7070101@FreeBSD.org> In-Reply-To: <CADLo838MFRnUrNQTv1Fo1r97zcRQceH-s2KDyqJwZY7gtMJetw@mail.gmail.com> References: <201303302045.r2UKj1wS062090@svn.freebsd.org> <51575F46.3050807@freebsd.org> <CADLo838MFRnUrNQTv1Fo1r97zcRQceH-s2KDyqJwZY7gtMJetw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2KQLTWAUFHXFOSPIXWJXA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 3/31/2013 11:02 AM, Chris Rees wrote: > On 30 March 2013 21:55, Niclas Zeising <zeising@freebsd.org> wrote: >> On 03/30/13 21:45, Joe Marcus Clarke wrote: >>> Author: marcus >>> Date: Sat Mar 30 20:45:00 2013 >>> New Revision: 315624 >>> URL: http://svnweb.freebsd.org/changeset/ports/315624 >>> >>> Log: >>> Make pkgconfig an explicit dependency of tshark. >>> >>> Modified: >>> head/net/wireshark/Makefile >>> >>> Modified: head/net/wireshark/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/net/wireshark/Makefile Sat Mar 30 18:54:34 2013 = (r315623) >>> +++ head/net/wireshark/Makefile Sat Mar 30 20:45:00 2013 = (r315624) >>> @@ -75,7 +75,7 @@ USE_GNOME+=3D gtk20 >>> WIRESHARK_LIBS+=3D${PTHREAD_LIBS} >>> .else >>> PLIST_SUB+=3D WIRESHARK=3D"@comment wireshark not built" >>> -USE_GNOME+=3D glib20 >>> +USE_GNOME+=3D glib20 pkgconfig >>> CONFIGURE_ARGS+=3D --enable-wireshark=3Dno \ >>> --disable-gtktest >>> .endif >>> >> >> You should use USE_PKGCONFIG=3Dbuild instead. >> >> A completely other thing: >> Isn't the ports tree frozen these days and require a Approved by: >> portmgr line in the commit msg? Perhaps something isn't working as it= >> should there. >> Regards! >=20 > Those hooks are not working at the moment, though I don't remember if > I specifically told Beat about it or just complained. >=20 > I've copied him in just in case he didn't know. >=20 > Another example: >=20 > http://svnweb.freebsd.org/ports/svnadmin/conf/access?revision=3D314635&= view=3Dmarkup >=20 > Chris >=20 The hook is working. portmgr are explicitly exempt from the check for "Approved by". See svnadmin/hooks/scripts/approvecheck.pl --=20 Regards, Bryan Drewery bdrewery@freenode/EFNet ------enig2KQLTWAUFHXFOSPIXWJXA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRWGAzAAoJEG54KsA8mwz55V0P/3bUg3+eg+/O70K8HAFffK2Z eSYq6wgyanWebQXy7ILcixNu187Wo3KKpdsI81nvP55m9diJtRvl4lvLEZfSoXBl 9tBHApjGohaGGEqqTvKdlnvKgzilUTzAYzvz2sXtaOd+KrHisTtEslMg64vNK5QT 8pzH1h1bglgPmnYkru5wYowD/e83KzljvqAta4DnXO3CNu5aeMo8IxPNEAWnaRo7 e0oWgtWEjdZj2jbaAMOwAkL8xQvS3vjm+id13vSFJLNm26zCp2L5Upmtc2FEh2JF xlLcPGwbaLQXKQIhlZZo+4Na2RGA4Rbef/CuFV/DVjfdD2ixE6sRhGdg6elX6/eF 1Ixj2CDk4jR1svrQ/1Y0HLyf1KfBYlnHa5BpT/xSM+8Po5/NtlwG4bW3lWeowYid ERfoRA2RXKIIn01iozgVlsHB1eepV/zni+0RIt2u+o1IWLaXti3p8n0NXdnBeqjl OEDF2/5BSoqlZOAeLk5fJ2OztIYXFkAOs0PpfW/cDHm0Y7FnOfmCGurONtkg/0zR I0tG+MaddbW7KVJbGQIM5s5QYPCbkNR7pY0MjZZewQUr9NkMb0nUL+TQ8qTw3xo0 MgfbTbbs/hBKjXYXYZmowHryfdk2HsPF7AzXJoPn1UtWpu0rXS6vL/rvQBLUr20e qsKD76H4gqkzRi5ziWOM =2jGX -----END PGP SIGNATURE----- ------enig2KQLTWAUFHXFOSPIXWJXA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5158602E.7070101>