Date: Tue, 27 Apr 2010 13:15:37 GMT From: pluknet <pluknet@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/146086: [patch] 64-bit aware printf() fixes at tools/tools/netrate Message-ID: <201004271315.o3RDFbBZ092343@www.freebsd.org> Resent-Message-ID: <201004271320.o3RDK2wh041270@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 146086
>Category: misc
>Synopsis: [patch] 64-bit aware printf() fixes at tools/tools/netrate
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Apr 27 13:20:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: pluknet
>Release: HEAD r207204
>Organization:
>Environment:
FreeBSD 9.0-CURRENT #10: Mon Apr 26 22:06:30 UTC 2010 root@xxx:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
64-bit aware printf() modifier fixes in tools/tools/netrate.
1) netrate/juggle
time_t has arch-dependent size
2) netrate/tcpconnect
uint64_t has %lu on 64bit, but %llu on 32bit
Replace these modifiers to begin with %j
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: tools/tools/netrate/tcpconnect/tcpconnect.c
===================================================================
--- tools/tools/netrate/tcpconnect/tcpconnect.c (revision 207204)
+++ tools/tools/netrate/tcpconnect/tcpconnect.c (working copy)
@@ -128,8 +128,8 @@
if (try_connect(&sin) == 0)
counter++;
}
- printf("%llu count\n", counter);
- printf("%llu connections/second\n", counter / SECONDS);
+ printf("%ju count\n", counter);
+ printf("%ju connections/second\n", counter / SECONDS);
return (0);
}
Index: tools/tools/netrate/juggle/juggle.c
===================================================================
--- tools/tools/netrate/juggle/juggle.c (revision 207204)
+++ tools/tools/netrate/juggle/juggle.c (working copy)
@@ -557,7 +557,7 @@
if (j != 0)
printf(", ");
scale_timespec(&juggle_results[j], p);
- printf("%u.%09lu", juggle_results[j].tv_sec,
+ printf("%ju.%09lu", juggle_results[j].tv_sec,
juggle_results[j].tv_nsec);
}
printf("\n");
@@ -567,7 +567,7 @@
if (j != 0)
printf(", ");
scale_timespec(&process_results[j], p);
- printf("%u.%09lu", process_results[j].tv_sec,
+ printf("%ju.%09lu", process_results[j].tv_sec,
process_results[j].tv_nsec);
}
printf("\n");
@@ -577,7 +577,7 @@
if (j != 0)
printf(", ");
scale_timespec(&thread_results[j], p);
- printf("%u.%09lu", thread_results[j].tv_sec,
+ printf("%ju.%09lu", thread_results[j].tv_sec,
thread_results[j].tv_nsec);
}
printf("\n");
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004271315.o3RDFbBZ092343>