Date: Wed, 20 Jul 2016 12:33:33 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <royger@FreeBSD.org>, Gleb Smirnoff <glebius@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302350 - in head: share/man/man9 sys/kern sys/sys Message-ID: <2026f486-d770-193d-34c1-8b93ec19b51e@FreeBSD.org> In-Reply-To: <8ed4b78f-71d3-9051-d435-ad0f9f3af124@selasky.org> References: <201607051847.u65IlIYf000901@repo.freebsd.org> <20160713084947.a4nfb6obr475pah6@mac> <b955c4a9-2fbe-55ee-fa15-16702cbe2074@selasky.org> <8ed4b78f-71d3-9051-d435-ad0f9f3af124@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/13/16 3:11 AM, Hans Petter Selasky wrote: > Hi, > > Can we agree on the following return values for callout_stop() and > callout_reset() and their variants: > > If the callout was scheduled regardless of being serviced or not, > .Dv CALLOUT_RET_CANCELLED > is returned. > If the callout was stopped and is still being serviced > .Dv CALLOUT_RET_DRAINING > is returned. > If the callout was stopped and is no longer being serviced > .Dv CALLOUT_RET_STOPPED > is returned. > > --HPS > I won't comment on the specific cases, but I do think we should move to using enums or macros for these return values and other parts of the KPI. The callout API is getting very abused lately, since r290664, and there seems to be a lack of review or consensus around most changes. Even in the recent changes, the review brought up several points that were seemingly ignored, and more that are still being ignored. The constant churn and reverts on this API is not acceptable. -- Regards, Bryan Drewery
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2026f486-d770-193d-34c1-8b93ec19b51e>