Date: Wed, 21 Nov 2018 23:17:44 -0600 From: Justin Hibbits <jhibbits@freebsd.org> To: kevans@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Li-Wen Hsu <lwhsu@freebsd.org> Subject: Re: svn commit: r339516 - head/sys/cddl/dev/dtrace/powerpc Message-ID: <CAHSQbTCN8MEsCqq9Bm3w1FcpF8FVCf8EE1V5ATEL%2Bz8pCqOSsQ@mail.gmail.com> In-Reply-To: <CACNAnaENKZJmTxR6sBWU%2BB5LBYgQbg0gP%2BoQq9CtRXbYfqkGhQ@mail.gmail.com> References: <201810210208.w9L28vVc080088@repo.freebsd.org> <CACNAnaEAGCnrtxyug=FGFneyM6VnAyzNr6Eb5ZDza-z525FRiQ@mail.gmail.com> <CACNAnaENKZJmTxR6sBWU%2BB5LBYgQbg0gP%2BoQq9CtRXbYfqkGhQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 21, 2018 at 10:02 PM Kyle Evans <kevans@freebsd.org> wrote: > > On Wed, Nov 21, 2018 at 9:42 PM Kyle Evans <kevans@freebsd.org> wrote: > > > > On Sat, Oct 20, 2018 at 9:09 PM Justin Hibbits <jhibbits@freebsd.org> wrote: > > > > > > Author: jhibbits > > > Date: Sun Oct 21 02:08:57 2018 > > > New Revision: 339516 > > > URL: https://svnweb.freebsd.org/changeset/base/339516 > > > > > > Log: > > > powerpc/dtrace: Use explicit bit numbers to mask out PSL_EE > > > > > > There seems to be a race in CI, such that dtrace_asm.S might be assembled > > > before the genassym is completed. This causes a build failure when PSL_EE > > > doesn't exist, and is read as 0. Get around this by explicitly specifying > > > the bits in the mask instead. > > > > > > > Hi, > > > > CI on the stable/12 branch still hits this, so I'm tempted to MFC this > > if you don't object. OTOH, the correct solution should be a > > `dependency "genassym.o"` in ^/sys/conf/files.powerpc for > > dtrace_asm.S, no? > > > > Sorry, that should have read "genassym.inc" -- my naive understanding > of 'dependency' is that config(8) will turn it directly into a > makefile dependency that will alleviate this. Hm, I'm surprised we don't have a rule for all kernel .S files, even modules, being dependent on that. Should we add one? - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHSQbTCN8MEsCqq9Bm3w1FcpF8FVCf8EE1V5ATEL%2Bz8pCqOSsQ>