Date: Wed, 10 Mar 2021 11:25:00 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Jessica Clarke <jrtc27@freebsd.org>, Olivier Houchard <cognet@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: c328f64d8107 - main - arm64: Fix COMPAT_FREEBSD32. Message-ID: <4e2cf000-991c-c09a-8c23-43ad4f5ef715@FreeBSD.org> In-Reply-To: <28B50FA6-65E4-4A5A-8339-8A4A8720974B@freebsd.org> References: <202103101807.12AI7IVW089870@gitrepo.freebsd.org> <28B50FA6-65E4-4A5A-8339-8A4A8720974B@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/10/21 10:36 AM, Jessica Clarke wrote: > On 10 Mar 2021, at 18:07, Olivier Houchard <cognet@FreeBSD.org> wrote: >> >> The branch main has been updated by cognet: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=c328f64d81079bad5064c8a387883df50ab5aaed >> >> commit c328f64d81079bad5064c8a387883df50ab5aaed >> Author: Olivier Houchard <cognet@FreeBSD.org> >> AuthorDate: 2021-03-10 18:01:41 +0000 >> Commit: Olivier Houchard <cognet@FreeBSD.org> >> CommitDate: 2021-03-10 18:06:42 +0000 >> >> arm64: Fix COMPAT_FREEBSD32. >> >> The ENTRY() macro was modified by commit >> 28d945204ea1014d7de6906af8470ed8b3311335 to add an optional NOP instruction >> at the beginning of the function. It is of course an arm64 instruction, so >> unsuitable for the 32bits sigcode. So just use EENTRY() instead for >> aarch32_sigcode. This should fix receiving signals when running 32bits >> binaries on FreeBSD/arm64. > > Hmm, that's a good point, does the extra nop for the AArch64 sigcode > cause issues for gdb detecting it? I think GDB might be ok because the nop comes first as it looks for the sequence of instructions after the nop to identify the signal frame (it doesn't care what instructions come before the sequence). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4e2cf000-991c-c09a-8c23-43ad4f5ef715>