Date: Fri, 19 Jun 2009 18:14:36 +0200 From: Hans Petter Selasky <hselasky@c2i.net> To: freebsd-usb@freebsd.org Cc: Andrew Thompson <thompsa@freebsd.org> Subject: Re: usb headers Message-ID: <200906191814.37536.hselasky@c2i.net> In-Reply-To: <20090618200655.GE19356@citylink.fud.org.nz> References: <20090618200655.GE19356@citylink.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 18 June 2009 22:06:56 Andrew Thompson wrote: > Hi, > > > Here is a patch that I want to get in, the changes are > > - Make usb_xfer opaque, the drivers can not grub around inside it > - Reduce the number if headers needed for a usb driver, the common case > is just usb.h and usbdi.h > > http://people.freebsd.org/~thompsa/usb_usbdi10.diff > > Any objections? > Hi, The patch looks good! Two things: Maybe "usbd_xfer_status(xfer, &actlen, NULL, NULL, NULL);" should include a pointer to the error code aswell? Instead of changing the callback prototype. One outstanding patch: http://perforce.freebsd.org/chv.cgi?CH=164675 Do you have any script to do any of those changes? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906191814.37536.hselasky>