Skip site navigation (1)Skip section navigation (2)
Date:      Thu,  4 Jan 1996 22:10:14 +0300 (MSK)
From:      =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (aka Andrey A. Chernov, Black Mage) <ache@astral.msk.su>
To:        davidg@Root.COM, Andras Olah <olah@cs.utwente.nl>
Cc:        current@freebsd.org, "Garrett A. Wollman" <wollman@lcs.mit.edu>
Subject:   Re: m_copydata panic & tcp_extensions: some results
Message-ID:  <wzMO2xm0l2@ache.dialup.ru>
In-Reply-To: <19542.820777477@curie.cs.utwente.nl>; from Andras Olah at Thu, 04 Jan 1996 18:44:37 %2B0100
References:  <19542.820777477@curie.cs.utwente.nl>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <19542.820777477@curie.cs.utwente.nl> Andras Olah writes:

>> olah        95/11/03 14:19:52
>> 
>>   Modified:    sys/netinet  tcp_timer.c
>>   Log:
>>   Setting the TF_ACKNOW flag was redundant in the REXMT timeout because
>>   tcp_output() checks for the condition snd_nxt == snd_una.
>>   
>>   Reviewed by:	davidg, wollman, olah
>>   Suggested by:	Richard Stevens

>This was not related to T/TCP, just a cosmetic change suggested by
>Richard Stevens on comp.protocols.tcp-ip some time ago. 
>Unfortunately, this change can cause the m_copydata panic if T/TCP
>is used (even if the application uses TCP in the traditional sense)
>and some segments are lost.  For the people interested in the
>anatomy of this bug, I'll describe the problem in full details.

Can you commit right fix into -current, please?
I can turn tcp_extensions ON and test it.

-- 
Andrey A. Chernov        : And I rest so composedly,  /Now, in my bed,
ache@astral.msk.su       : That any beholder  /Might fancy me dead -
http://dt.demos.su/~ache : Might start at beholding me,  /Thinking me dead.
RELCOM Team,FreeBSD Team :         E.A.Poe         From "For Annie" 1849



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?wzMO2xm0l2>