Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 05 Aug 2000 18:04:10 -0600
From:      "Justin T. Gibbs" <gibbs@plutotech.com>
To:        Bill Paul <wpaul@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/aic7xxx ahc_pci.c 
Message-ID:  <200008060003.SAA68110@pluto.plutotech.com>
In-Reply-To: Your message of "Fri, 04 Aug 2000 11:09:56 PDT." <200008041809.LAA04652@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
>wpaul       2000/08/04 11:09:56 PDT
>
>  Modified files:
>    sys/dev/aic7xxx      ahc_pci.c 
>  Log:
>  The check_extport() function appears to have some new code in it that checks
>  the scratch RAM for data normally found in the SEEPROM (presumably in the
>  event that the SEEPROM is unavailable or can't be read).

You could have found out for sure by contacting the maintainer of this
driver, posting to the -SCSI list, or sending a full and complete PR
(you do know how to do this don't you?).

>  This code causes a spontaneous reboot on monster.osd.bsdi.com, which has
>  an embedded aic7880 >  controller. The problem appears to happen either
>  when it writes to the SCBPTR port and then reads from the SCB_CONTROL
>  port. Somewhere during the inb/outb operations, the system has a heart
>  attack and restarts.

Interesting.  But, barring a valid PR or useful diagnosis, I suppose
I should just re-enable this code and ignore this message... much as
some other developers I know.

>  I stronly suggest that it stay #ifdef'ed out until it's properly tested.

Guess what?  You are probably one of the only FreeBSD users on the
planet that can test the code.  It should only trigger on certain
embedded aic78XX applications and I don't have access to any of
these motherboards.  The only way for me to test this feature is
to push it out into -current.  Last I checked, this in one of the
reasons -current exists.

In the future, contact the maintainer.  There was absolutely no
urgency to get this change into the tree - you are the only person
who has been affected by this code and you know how to back-out/fix
the problem locally - and the maintainer is *actively* supporting
this code.

If you really want to be helpful, follow your own PR submission
instructions and send me a PR.

--
Justin


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200008060003.SAA68110>