Date: Mon, 25 Aug 2014 09:43:02 -0400 From: Adam Weinberger <adamw@adamw.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r365735 - in head/games: . prboom-plus Message-ID: <F714F3E9-01A2-4D60-99D3-7EA6136CFF75@adamw.org> In-Reply-To: <20140825093243.GC66191@FreeBSD.org> References: <201408231404.s7NE4Ds7036892@svn.freebsd.org> <20140825093243.GC66191@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 Aug, 2014, at 5:32, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > On Sat, Aug 23, 2014 at 02:04:13PM +0000, Adam Weinberger wrote: >> New Revision: 365735 >> URL: http://svnweb.freebsd.org/changeset/ports/365735 >> QAT: https://qat.redports.org/buildarchive/r365735/ >>=20 >> @@ -0,0 +1,43 @@ >> +# Created by: Jordan DeLong <fracture@allusion.net> >> +# $FreeBSD$ >> + >> +PORTNAME=3D prboom-plus >> +PORTVERSION=3D 2.5.1.3 >> +CATEGORIES=3D games >> +MASTER_SITES=3D SF/${PORTNAME}/${PORTNAME}/${PORTVERSION} >> + >> +MAINTAINER=3D thiagohero501@gmail.com >> +COMMENT=3D A fork of the doom game engine prboom >=20 > COMMENT line is wrong. :) Because it starts with an article? I=92d posit that that article = improves readability of this particular COMMENT. >=20 >> Added: head/games/prboom-plus/Makefile.include >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- /dev/null 00:00:00 1970 (empty, because file is newly = added) >> +++ head/games/prboom-plus/Makefile.include Sat Aug 23 14:04:12 2014 = (r365735) >> @@ -0,0 +1,24 @@ >> +# Makefile for defining variables used by other Doom related ports. >> + >> +DMPKGNAMEPREFIX?=3D doom- >> +DMDIR?=3D ${LOCALBASE}/share/doom >> + >> +.if defined(PKGNAMEPREFIX) && ${PKGNAMEPREFIX} =3D=3D = ${DMPKGNAMEPREFIX} && defined(OPTIONSMKINCLUDED) >> +. error include before <bsd.port.options.mk> if using = DMPKGNAMEPREFIX >> +.endif >> + >> +MAKE_ENV+=3D DMDIR=3D"${DMDIR}" >> +PLIST_SUB+=3D DMDIR=3D"${DMDIR:S/${LOCALBASE}\///}" >> +SUB_LIST+=3D DMDIR=3D"${DMDIR}" >> + >> +.if defined(USE_CRLF) >> +. if defined(USE_ZIP) >> +EXTRACT_BEFORE_ARGS=3D -aqo >> +. else >> +pre-patch: >> + @${FIND} ${WRKDIR} -type f -print0 | \ >> + ${XARGS} -0 ${FILE} | ${GREP} 'CRLF' | \ >> + ${SED} -e "s/:.*//" | ${SED} -e 's/ /\\ /g' | \ >> + ${XARGS} ${REINPLACE_CMD} -i "" -e "s/`${PRINTF} = '\r'`$$//" >> +. endif >> +.endif >=20 > This looks like the old version of the doom-data/Makefile.include = file. Why > it was copied here. Submitter should've taken a look at other Doom = ports to > see how to properly use this file. > I=92m aware, and I noted it in the PR. Some the stuff in there is = useless, and I removed even more nonsense out of what was originally = submitted, but some of it actually does stuff, so I decided, why the = hell not. Feel free to rip it out and clean it up if you=92d like. > It would be nice to have this patch first reviewed by games@. After spending a lot of time fixing endless build failures, preventing = things from controlling examples with DOCS, and sending emails to = mailing lists and never getting replies, I=92ve come to the conclusion = that hat groups are largely for show. I cannot tell you how much I=92d = love to be proven wrong. It=92s hard to know which hat groups are = active, and which just collects ports and hope someone else will fix = them for them. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F714F3E9-01A2-4D60-99D3-7EA6136CFF75>