Date: Mon, 21 Jun 2004 12:39:37 +0100 From: Lewis Thompson <lewiz@fajita.org> To: Volker Stolz <vs@freebsd.org> Cc: lars.eggert@gmx.net Subject: Re: Freevo port (TESTING REQUIRED). Message-ID: <20040621113937.GA83826@fajita.org> In-Reply-To: <20040621070848.GA78206@i2.informatik.rwth-aachen.de> References: <20040620232712.GA75329@fajita.org> <200406202328.06979.mistry.7@osu.edu> <20040621070848.GA78206@i2.informatik.rwth-aachen.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 21, 2004 at 09:08:48AM +0200, Volker Stolz wrote: > In local.freebsd-ports, you wrote: > >> I've been working on a port of Freevo (http://freevo.sf.net/), which is > >> ``an open-source home theatre PC platform'', for a while now and > >> hopefully within a week or two version 1.5.0 will be released. >=20 > Lewis' submission looks more complete to me. I'd say go ahead and send-pr. > Please fix some of the deficiencies reported by portlint before, most not= ably: >=20 > 1) > WARN: /usr/tmp/freevo/pkg-plist: Both ``%%PORTDOCS%%@dirrm %%DOCSDIR%%'' = and ``%%PORTDOCS%%@unexec %D/%%DOCSDIR%% 2>/dev/null || true'' are missing.= At least one should be used. > FATAL: Makefile: PORTVERSION looks illegal. You should modify "1.5.0rc3". Hmm, I must admit I completely forgot to run it past portlint (although I was aware that 1.5.0rc3 was an invalid PORTVERSION). I wouldn't have spotted the other WARN though, I've only used it minimally before and I have to run with --help to figure out the extra options! Thanks for that! > 3) > I don't understand your WITH-handling: >=20 > .if !defined(WITH_MPLAYER) > WITH_MPLAYER=3D yes > .endif Well, it seemed to me that if WITH_MPLAYER=3D0 was specified to make then WITH_MPLAYER was defined. However, if no option was defined then I want to install mplayer -- this seemed a nice way to do it at the time. Have I missed the plot here? Thanks for the info, -lewiz. --=20 I was so much older then, I'm younger than that now. --Bob Dylan, 1964. ------------------------------------------------------------------------ -| msn:purple@lewiz.net | jabber:lewiz@jabber.org | url:www.lewiz.org |- --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA1sj5Itq0KFQv7T8RAh5wAKD5oF1/OKPPjs4p4Ioz5cK33G0MfgCfa2oh KETB5paIjRfMps/jjdebMsE= =W1kd -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040621113937.GA83826>