Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 01 Oct 2015 11:22:48 -0700
From:      John Baldwin <jhb@freebsd.org>
To:        src-committers@freebsd.org
Cc:        svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r288454 - head/usr.bin/truss
Message-ID:  <5360523.S6ag5ugNqo@ralph.baldwin.cx>
In-Reply-To: <201510011728.t91HS7fo006633@repo.freebsd.org>
References:  <201510011728.t91HS7fo006633@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, October 01, 2015 05:28:07 PM John Baldwin wrote:
> Author: jhb
> Date: Thu Oct  1 17:28:07 2015
> New Revision: 288454
> URL: https://svnweb.freebsd.org/changeset/base/288454
> 
> Log:
>   - Remove extra integer argument from truncate() and ftruncate().  This is
>     probably fallout from the removal of the extra padding argument before
>     off_t in 7.  However, that padding still exists for 32-bit powerpc, so
>     use QUAD_ALIGN.
>   - Fix QUAD_ALIGN to be zero for powerpc64.  It should only be set to 1
>     for 32-bit platforms that add padding to align 64-bit arguments.

I'm not sure how the situation is on arm and MIPS, but on powerpc, both the
32-bit and 64-bit platforms define __powerpc__ (unlike amd64 which doesn't
define __i386__ for example) making proper #ifdef's for just 32-bit
__powerpc__ a bit of a PITA.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5360523.S6ag5ugNqo>