Date: Mon, 13 Jan 2014 16:50:07 +0100 From: Rusmir Dusko <nemysis@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r338474 - head/net-p2p/libtorrent-rasterbar Message-ID: <20140113155007.GA13066@nemysis4now>
next in thread | raw e-mail | index | archive | help
> On Thu, Jan 02, 2014 at 07:47:58PM +0000, Rusmir Dusko wrote: > > New Revision: 338474 > > URL: http://svnweb.freebsd.org/changeset/ports/338474 > > > > Log: > > - Bump PORTREVISION > > - Fix build on 8.x and 9.x > > - Use USES=compiler:c++11-lang instead of compiler > Can you elaborate a bit on the necessity of USES=compiler:c++11-lang here? > I didn't notice any C++11 features used in the source code; at least base > GCC builds it just fine. There is a problem with ./configure script: it > passes -ftemplate-depth=120 option during Boost detection; but that can be > easily remedied with simple sed(1) script. Would you consider attached > patch? Thanks i will elaborate your patch. This is good -CONFIGURE_ARGS+= --disable-debug \ +CONFIGURE_ARGS= --disable-debug \ I don't approve this, because it is needed for successful build on PointyHat -USES= compiler:c++11-lang pathfix pkgconfig iconv +USES= pathfix pkgconfig icon This is unnecessary, Clang and GCC have this Option: http://clang.llvm.org/docs/genindex.html http://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html + @${REINPLACE_CMD} -e '/-ftemplate-depth/d' ${WRKSRC}/configure This is good break lines around 80 characters, i use this for all Ports - ${INSTALL_DATA} ${PORTEXAMPLES:S|^|${WRKSRC}/examples/|} ${STAGEDIR}${EXAMPLESDIR} + ${INSTALL_DATA} ${PORTEXAMPLES:S|^|${WRKSRC}/examples/|} \ + ${STAGEDIR}${EXAMPLESDIR} Build log on RedPorts is not relevant, important is from PointyHat https://redports.org/buildarchive/20140113145200-49735/ This build on RedPorts was good but failed on PointyHat, I think this is too with your diff https://redports.org/buildarchive/20140102183201-55841/ -- Best regards, Rusmir Dusko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140113155007.GA13066>