Date: Mon, 24 Feb 2014 13:09:51 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r345889 - head/editors/vim Message-ID: <530B98FF.5060506@FreeBSD.org> In-Reply-To: <CAMHz58R=UXsd-Akw7jfRfH_%2BPQGHLkCZk_6JdF1sHS=5AUkJDQ@mail.gmail.com> References: <201402241844.s1OIiGOe058833@svn.freebsd.org> <530B949A.5020805@FreeBSD.org> <CAMHz58R=UXsd-Akw7jfRfH_%2BPQGHLkCZk_6JdF1sHS=5AUkJDQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --psMoWf5wA0e2dOni5uMAaxJLEAwqqfPp1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2/24/2014 1:05 PM, Sunpoet Po-Chuan Hsieh wrote: > On Tue, Feb 25, 2014 at 2:51 AM, Bryan Drewery <bdrewery@freebsd.org > <mailto:bdrewery@freebsd.org>> wrote: >=20 > On 2/24/2014 12:44 PM, Sunpoet Po-Chuan Hsieh wrote: > > Author: sunpoet > > Date: Mon Feb 24 18:44:16 2014 > > New Revision: 345889 > > URL: http://svnweb.freebsd.org/changeset/ports/345889 > > QAT: https://qat.redports.org/buildarchive/r345889/ > > > > Log: > > - Fix lua support > > > > PR: ports/186917 > > Submitted by: Kenji Rikitake <kenji@k2r.org > <mailto:kenji@k2r.org>> > > > > Modified: > > head/editors/vim/Makefile > > > > Modified: head/editors/vim/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/editors/vim/Makefile Mon Feb 24 18:39:50 2014 =20 > (r345888) > > +++ head/editors/vim/Makefile Mon Feb 24 18:44:16 2014 =20 > (r345889) > > @@ -159,7 +159,7 @@ pre-configure: > > @${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \ > > -e > 's|\$$gtk_config_prefix/bin/gtk-config|\$${GTK_CONFIG}|g' \ > > -e > 's|\$$gtk_config_exec_prefix/bin/gtk-config|\$${GTK_CONFIG}|g' \ > > - -e 's|set dummy lua;|set dummy lua-${LUA_VER};|g' > ${WRKSRC}/src/auto/configure > > + -e 's|set dummy lua;|set dummy ${LUA_CMD};|g' > ${WRKSRC}/src/auto/configure > > .if ${PORT_OPTIONS:MXTERM_SAVE} > > @${REINPLACE_CMD} -e '/FEAT_XTERM_SAVE/ s|.*|#define > FEAT_XTERM_SAVE|' ${WRKSRC}/src/feature.h > > .endif > > >=20 > Was this a build-time failure or runtime change? The PR suggests a > runtime issue. If runtime needs a PORTREVISION bump, regardless of > default options. >=20 >=20 > I just made a PORTREVISION bump in r345888 which is 5 minutes before > this commit. > IIRC, does the 10-minute rule apply? Technically yes it needs a bump. Someone may have built packages in those 5 minutes. They may have email hooks on updates to their ports to trigger builds. Maybe they build ports at :40 minute marker. Who knows. I've frequently hit problems in packages because the revision was not bumped. Without it you now have 2 different behaving 7.4*_1 packages. I understand if you don't want to bump it now, just try to group runtime changes better next time :) --=20 Regards, Bryan Drewery --psMoWf5wA0e2dOni5uMAaxJLEAwqqfPp1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTC5j/AAoJEDXXcbtuRpfPglkH/A0uL01j6uk3DDwuYrfBA8PI F1dNP89sevoygzv+vykDu5g7E+bTO+xBXIVqNxblRDkYGLjpBnH8Po5zWb5uH265 i6V6omP5cJJymmXD3ZND4Wz1TnYc4/DES1Q/LUuiBGYYclE7qz0XX0E4QLkh5v4+ qu9b02OwYEYIa06fljGeiisXmYE1qN6rxjXTIFGHiK9BtDiV39asU+yvLHGEl+CN FD7ay1Qg1tTilLpd7pzv5iHQdsena6PS+5Ss2LqDsUtZEQmo2Z/U3CFt3M5txtyj p828OQGe/H0dBWaiBSp4jalS44atGFYPXHsq8IbKwILA0hh5MNLI5DgzttuHNHE= =CpSQ -----END PGP SIGNATURE----- --psMoWf5wA0e2dOni5uMAaxJLEAwqqfPp1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?530B98FF.5060506>