Date: Mon, 11 Mar 2013 17:43:24 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Joshua Isom <jrisom@gmail.com> Cc: "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org> Subject: Re: Fine, OK, here's my initial AR9380/AR9485 support Message-ID: <CAJ-Vmok2ONOJsZK4BuD9J5drUpmjri6mV-dB4N7-9HvuGcVV0Q@mail.gmail.com> In-Reply-To: <CAJ-VmomWgitUZvxVQbQc6qFu8rOYJVZiZCrVEjQm2fOdp5Sz7w@mail.gmail.com> References: <513d3ae3.08c2440a.59a6.63b2@mx.google.com> <513DA767.6010208@gmail.com> <CAJ-Vmo=uSeKK1SV3k_nRLDSHShobiyN6ky861b5NDn_U8NxukQ@mail.gmail.com> <513E6AF5.9010304@gmail.com> <CAJ-Vmo=9Kj41=J3m6SapXi0y6t9cF-A=XCX8AWz0qirLnrwX=Q@mail.gmail.com> <513E7924.3060302@gmail.com> <CAJ-VmomWgitUZvxVQbQc6qFu8rOYJVZiZCrVEjQm2fOdp5Sz7w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
.. and yeah, that code is wrong. GCC doesn't complain; just change it to:
if ((ahp->ah_enterprise_mode && AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) &&
to:
if ((ahp->ah_enterprise_mode & AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) &&
Thanks, this is the first bug that I can file as having come from the
FreeBSD community. :)
Adrian
On 11 March 2013 17:41, Adrian Chadd <adrian@freebsd.org> wrote:
> Is this with clang?
>
>
>
>
> adrian
>
>
> On 11 March 2013 17:39, Joshua Isom <jrisom@gmail.com> wrote:
>> Still no luck, and some errors look like I'm missing more.
>>
>>
>> /root/ATH/head/sys/modules/ath/../../dev/ath/ath_hal/ar9003/ar9300_misc.c:853:38:
>> error: use of logical '&&' with constant operand
>> [-Werror,-Wconstant-logical-operand]
>> if ((ahp->ah_enterprise_mode && AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) &&
>> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> AR_ENT_OTP_MIN_PKT_SIZE_DISABLE is defined in ar9300reg.h and hardcoded.
>>
>> At least you figured out an easy way to genuine check to see if someone
>> tried your code.
>>
>>
>> On 3/11/2013 6:41 PM, Adrian Chadd wrote:
>>>
>>> Ooh.. add the debug options to your kernel, sorry!
>>>
>>> options ATH_DEBUG
>>> options AH_DEBUG
>>> options ATH_DIAGAPI
>>>
>>> I'm sorry, I've never tested it outside of a debug build before.
>>>
>>>
>>>
>>>
>>> Adrian
>>>
>>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmok2ONOJsZK4BuD9J5drUpmjri6mV-dB4N7-9HvuGcVV0Q>