Date: Wed, 27 Feb 2002 09:45:11 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Bruce Evans <bde@zeta.org.au> Cc: Mikhail Teterin <mi@aldan.algebra.com>, brooks@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/awi if_awi_pccard.c Message-ID: <20020227094511.A546@Odin.AC.HMC.Edu> In-Reply-To: <20020227224407.P48555-100000@gamplex.bde.org>; from bde@zeta.org.au on Wed, Feb 27, 2002 at 10:56:38PM %2B1100 References: <200202262044.g1QKigX25029@aldan.algebra.com> <20020227224407.P48555-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--qDbXVdCdHGoSgWSk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 27, 2002 at 10:56:38PM +1100, Bruce Evans wrote: > This an indication that if_name should have type "const char *", and > that we don't have -Wwrite-strings turned on for the kernel yet. >=20 > device_get_name(dev) already returns "const char *". The change should > have no effect on the warning, but "works" because -Wwrite-strings is > not turned on so the compiler can't see that "awi" also has type > "const char *". >=20 > We are a long way from having a const-clean kernel, due to the missing > -Wwrite-strings and missing consts at strategic places (mainly at > syscall entry points). My thought was that this fix was wrong (though I didn't realize that it shouldn't work) but I wanted to get the kernel building without current warnings before screwing around with struct ifnet since that's likely to create even more warnings. Once we've got LINT more or less working again, I'd like to see this change go in or possiably a conversion to the NetBSD style if_xname (replacing if_name and if_unit). If you have a suggestion for a less bogus interim fix, I'd be happy to commmit it. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --qDbXVdCdHGoSgWSk Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE8fRsmXY6L6fI4GtQRAtGHAKCNw2Gv1soIn2mvhBa5hXLmvJbf6gCfeYxL nXOLAy4G6qMkrnqcL6yjde0= =V8yT -----END PGP SIGNATURE----- --qDbXVdCdHGoSgWSk-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020227094511.A546>