Date: Sun, 29 Mar 2020 19:46:07 +0000 From: Brooks Davis <brooks@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: Enji Cooper <ngie@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359385 - head/usr.bin/kyua Message-ID: <20200329194607.GB40889@spindle.one-eyed-alien.net> In-Reply-To: <2A7EAECB-C11A-458C-9495-BC975300D363@gmail.com> References: <202003280108.02S18KWc062782@repo.freebsd.org> <20200328032209.GA40889@spindle.one-eyed-alien.net> <D84490BA-98F4-4421-8453-1FD23936D1A0@gmail.com> <2A7EAECB-C11A-458C-9495-BC975300D363@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--/NkBOFFp2J2Af1nK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 28, 2020 at 07:42:04PM -0700, Enji Cooper wrote: >=20 > > On Mar 28, 2020, at 7:37 PM, Enji Cooper <yaneurabeya@gmail.com> wrote: > >=20 > >>=20 > >> On Mar 27, 2020, at 8:22 PM, Brooks Davis <brooks@freebsd.org <mailto:= brooks@freebsd.org>> wrote: > >>=20 > >> On Sat, Mar 28, 2020 at 01:08:20AM +0000, Enji Cooper wrote: > >>> Author: ngie > >>> Date: Sat Mar 28 01:08:20 2020 > >>> New Revision: 359385 > >>> URL: https://svnweb.freebsd.org/changeset/base/359385 <https://svnweb= =2Efreebsd.org/changeset/base/359385> > >>>=20 > >>> Log: > >>> Check in the generated copies of the manpages > >>>=20 > >>> These manpages were meant to be templated once per `configure` run. > >>>=20 > >>> Given that we're not bound by as many constants, e.g., `--prefix` is= n't > >>> generally changing for kyua in the base system, having to generate t= he > >>> manpages each build seems slightly less than optimal. > >>>=20 > >>> In the event that one's build environment doesn't define `$SH`, the = build > >>> will also fail until this change is introduced. > >>>=20 > >>> Instead of jumping through hoops dealing with shells or permissions,= let's > >>> just cut to the chase and check the generated copies into the source= base > >>> under usr.bin/kyua . > >>=20 > >> This was the wrong fix. Committing generated manpaged was > >> 100% the wrong solution and will make extra work in the > >> future. The correct fix is almost certainly the one attached to > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245086 <https://bu= gs.freebsd.org/bugzilla/show_bug.cgi?id=3D245086>. If someone > >> doesn't beat me to it I will revert you wrong and broken commit along > >> with the followups and commit the correct one (this certainly won't be > >> until at least tomorrow). > >=20 > > I???ll revert my changes. >=20 > Done in r359417. Thank you! -- Brooks --/NkBOFFp2J2Af1nK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJegPr+AAoJEKzQXbSebgfAcDoH/jHGMExVpniE2bbsITQR5MA3 FzFfcWJ/OPtEShcTNDhPiYePrcXXE+tcGP8bvcQKmzWRYw05qKeXKYn8MZZ/FNBc bPLF3zP8POpd6ph+N+0XTsLXn8lliw8pZ1UnlJ20rkFwKZWuEv67TwcZ9U1Ut9VV y2AyqpIC0OZOTY95DCc4/T6UzxWWMePuSJFliol4DUxO0fjLC5pAvvYi6Ep135fL YrPetjkofYm66iT3gvhvVSJ/9jM7y4u/ivEK8a1aMHoNZsbBEKi1IGv8l5bOfADz HTZp8v4dB6U41WbNy+38yZWsMffr046eNLQGZodQu9WvN7JvkZg2cS4c8zKMydg= =kV6m -----END PGP SIGNATURE----- --/NkBOFFp2J2Af1nK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200329194607.GB40889>