Date: Fri, 9 Dec 2011 16:10:11 GMT From: mdf@FreeBSD.org To: freebsd-bugs@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Message-ID: <201112091610.pB9GABlJ083510@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/163076; it has been noted by GNATS. From: mdf@FreeBSD.org To: Jaakko Heinonen <jh@freebsd.org> Cc: =?ISO-8859-1?Q?Dag=2DErling_Sm=F8rgrav?= <des@des.no>, Poul-Henning Kamp <phk@phk.freebsd.dk>, Petr Salinger <Petr.Salinger@seznam.cz>, bug-followup@freebsd.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Date: Fri, 9 Dec 2011 07:33:46 -0800 2011/12/9 Jaakko Heinonen <jh@freebsd.org>: > On 2011-12-09, Dag-Erling Sm=F8rgrav wrote: >> > Could we just remove the error check from sbuf_len()? (patch below) I >> > have Cc'd more people. >> >> Why? > > As I wrote existing code depends on sbuf_len() to return the actual > length regardless of the error status after sbuf_finish(). I am not > willing to through all code using sbufs to check where it causes > problems. phk@ asserts that r222004 is correct. What is causing sbuf to have an error in the first place? The size of flies in /proc are generally small and malloc(3) errors are rare. Thanks, matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112091610.pB9GABlJ083510>