Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Aug 2014 09:55:28 -0400
From:      Adam Weinberger <adamw@adamw.org>
To:        marino@freebsd.org
Cc:        svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, Adam Weinberger <adamw@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r365735 - in head/games: . prboom-plus
Message-ID:  <9A340EAF-EEDD-4D38-B4D8-5FD3C2C9EED7@adamw.org>
In-Reply-To: <53FB3FB3.90508@marino.st>
References:  <201408231404.s7NE4Ds7036892@svn.freebsd.org> <20140825093243.GC66191@FreeBSD.org> <F714F3E9-01A2-4D60-99D3-7EA6136CFF75@adamw.org> <53FB3FB3.90508@marino.st>

next in thread | previous in thread | raw e-mail | index | archive | help
On 25 Aug, 2014, at 9:52, John Marino <freebsd.contact@marino.st> wrote:

> On 8/25/2014 15:43, Adam Weinberger wrote:
>> On 25 Aug, 2014, at 5:32, Alexey Dokuchaev <danfe@FreeBSD.org>
>> wrote:
>>> COMMENT line is wrong. :)
>>=20
>> Because it starts with an article? I=92d posit that that article
>> improves readability of this particular COMMENT.
>=20
> Yes, because it starts with an article.   We've been instructed to
> remove them unconditionally.
> Hundreds of ports have comments equivalent to "Fork of the doom game
> engine prboom", so it's not special in any way.
>=20
> Unfortunately portlint doesn't check for this.  I'd add this to the
> current catch-all portlint rule PR.

Guys, if it=92s not right, please just fix it!

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9A340EAF-EEDD-4D38-B4D8-5FD3C2C9EED7>